Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2131373002: Add @abstract to allowed Closure linter tags (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add @abstract to allowed Closure linter tags Also shuffle around some JSDoc @tag-related code R=dpapad@chromium.org BUG=567770 NOTRY=true Committed: https://crrev.com/9d2d86973416c50f356b737d5787987ae1707a57 Cr-Commit-Position: refs/heads/master@{#404489}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M chrome/browser/web_dev_style/js_checker.py View 1 chunk +13 lines, -3 lines 1 comment Download
M third_party/closure_compiler/closure_args.gni View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/closure_compiler/closure_args.gypi View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Dan Beam
4 years, 5 months ago (2016-07-08 19:15:01 UTC) #1
dpapad
lgtm
4 years, 5 months ago (2016-07-08 19:18:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131373002/1
4 years, 5 months ago (2016-07-08 21:12:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 21:17:16 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 21:17:32 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9d2d86973416c50f356b737d5787987ae1707a57 Cr-Commit-Position: refs/heads/master@{#404489}
4 years, 5 months ago (2016-07-08 21:20:07 UTC) #12
Dan Beam
4 years, 5 months ago (2016-07-11 21:13:26 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/2131373002/diff/1/chrome/browser/web_dev_styl...
File chrome/browser/web_dev_style/js_checker.py (right):

https://codereview.chromium.org/2131373002/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/js_checker.py:197: 'polymerBehavior'
why, yes it could be related to this! :P

Powered by Google App Engine
This is Rietveld 408576698