Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: chrome/browser/web_dev_style/js_checker.py

Issue 2131373002: Add @abstract to allowed Closure linter tags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/closure_compiler/closure_args.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_dev_style/js_checker.py
diff --git a/chrome/browser/web_dev_style/js_checker.py b/chrome/browser/web_dev_style/js_checker.py
index cba3eae514b3048b5f65de3317769dc2b2d156a2..e290673831c341891004e0f71e0ff3babcbd161d 100644
--- a/chrome/browser/web_dev_style/js_checker.py
+++ b/chrome/browser/web_dev_style/js_checker.py
@@ -185,9 +185,19 @@ class JSChecker(object):
errors.MISSING_JSDOC_TAG_THIS,
]
- # Whitelist Polymer-specific JsDoc tags.
- gflags.FLAGS.custom_jsdoc_tags = ('group', 'element', 'attribute',
- 'default', 'polymerBehavior')
+ # Keep this in sync with third_party/closure_compiler/closure_args.gypi
+ gflags.FLAGS.custom_jsdoc_tags = (
+ 'abstract',
+ 'attribute',
+ 'default',
+ 'demo',
+ 'element',
+ 'group',
+ 'hero',
+ 'polymerBehavior'
Dan Beam 2016/07/11 21:13:26 why, yes it could be related to this! :P
+ 'status',
+ 'submodule',
+ )
error_handler = ErrorHandlerImpl(self.input_api.re)
runner.Run(file_to_lint, error_handler, source=source)
return error_handler.GetErrors()
« no previous file with comments | « no previous file | third_party/closure_compiler/closure_args.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698