Do not use the fixed height for HTML select element if appearance is none.

Do not use the fixed height for HTML select element if appearance is none.

This patch fixes the problem when a text appears chopped in HTML select element with -webkit-appearance:none. If appearance:none then we should use the height that is calculated based using platform-native styling based on the users' operating system's theme.

R=eae@chromium.org
BUG=626278
TEST=third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html

Committed: https://crrev.com/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6
Cr-Commit-Position: refs/heads/master@{#405066}

[Gleb Lanbin, 2016-07-08 21:50:13]

Description was changed from

==========
Do not use the fixed height if appearance is none.
BUG=
==========

to

==========
Do not use the fixed height for HTML select element if appearance is none.

This patch fixes the problem when a text appears chopped in HTML select element
with -webkit-appearance:none. If appearance:none then we should use the height
that is calculated based using platform-native styling based on the users'
operating system's theme.

R=eae@chromium.org
BUG=626278
TEST=third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html
==========

[Gleb Lanbin, 2016-07-08 21:53:44]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2016-07-08 21:54:00]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 21:54:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gleb Lanbin, 2016-07-08 21:58:53]

glebl@chromium.org changed reviewers:
+ eae@chromium.org

[commit-bot: I haz the power, 2016-07-09 00:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 00:21:23]

Dry run: This issue passed the CQ dry run.

[eae, 2016-07-12 16:16:35]

LGTM

[eae, 2016-07-12 16:18:54]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-07-12 16:20:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 16:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 16:35:50]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Gleb Lanbin, 2016-07-12 20:27:00]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-07-12 20:27:00]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2131303003/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-07-12 20:29:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 22:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 22:55:47]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2016-07-12 22:56:30]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2016-07-12 22:58:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:15:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 02:15:47]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1367
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/LayoutTests/TestExpectations' with
conflicts.
  U third_party/WebKit/LayoutTests/TestExpectations

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
471589c035fcd23a2ca210307e17c4a7ddb6cb91..f39bebbabda4645c1edbe9f5c586c9c499e90b1b
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1367,3 +1367,5 @@ crbug.com/624709 [ Win ]
virtual/gpu-rasterization/fast/images/webp-color-profil
 crbug.com/625020 [ Debug ] compositing/repaint/page-scale-repaint.html [
Timeout ]
 
 crbug.com/620432 accessibility/aria-activedescendant.html [ Failure ]
+
+crbug.com/626278 fast/forms/select/menulist-appearance-none.html [
NeedsRebaseline ]

[commit-bot: I haz the power, 2016-07-13 02:16:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 02:16:20]

CQ bit was unchecked.

[Gleb Lanbin, 2016-07-13 02:22:24]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-07-13 02:22:25]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2131303003/#ps60001
(title: "2nd rebase")

[commit-bot: I haz the power, 2016-07-13 02:24:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 04:10:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 04:10:28]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1392
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/LayoutTests/TestExpectations' with
conflicts.
  U third_party/WebKit/LayoutTests/TestExpectations

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
410f3eb86b35b11fc4f23955d6f18030801d6113..b175377f15604812047c58c8fcaaed1267df5efd
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1392,3 +1392,4 @@ crbug.com/625020 [ Debug ]
compositing/repaint/page-scale-repaint.html [ Timeout
 crbug.com/620432 accessibility/aria-activedescendant.html [ Failure ]
 
 crbug.com/578252 csspaint/paint2d-zoom.html [ NeedsRebaseline ]
+crbug.com/626278 fast/forms/select/menulist-appearance-none.html [
NeedsRebaseline ]

[commit-bot: I haz the power, 2016-07-13 04:10:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 04:10:44]

CQ bit was unchecked.

[Gleb Lanbin, 2016-07-13 04:55:48]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-07-13 04:55:48]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2131303003/#ps80001
(title: "3rd rebase")

[commit-bot: I haz the power, 2016-07-13 04:56:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 07:13:52]

Description was changed from

==========
Do not use the fixed height for HTML select element if appearance is none.

This patch fixes the problem when a text appears chopped in HTML select element
with -webkit-appearance:none. If appearance:none then we should use the height
that is calculated based using platform-native styling based on the users'
operating system's theme.

R=eae@chromium.org
BUG=626278
TEST=third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html
==========

to

==========
Do not use the fixed height for HTML select element if appearance is none.

This patch fixes the problem when a text appears chopped in HTML select element
with -webkit-appearance:none. If appearance:none then we should use the height
that is calculated based using platform-native styling based on the users'
operating system's theme.

R=eae@chromium.org
BUG=626278
TEST=third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html
==========

[commit-bot: I haz the power, 2016-07-13 07:13:53]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-07-13 07:13:59]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 07:16:56]

Description was changed from

==========
Do not use the fixed height for HTML select element if appearance is none.

This patch fixes the problem when a text appears chopped in HTML select element
with -webkit-appearance:none. If appearance:none then we should use the height
that is calculated based using platform-native styling based on the users'
operating system's theme.

R=eae@chromium.org
BUG=626278
TEST=third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html
==========

to

==========
Do not use the fixed height for HTML select element if appearance is none.

This patch fixes the problem when a text appears chopped in HTML select element
with -webkit-appearance:none. If appearance:none then we should use the height
that is calculated based using platform-native styling based on the users'
operating system's theme.

R=eae@chromium.org
BUG=626278
TEST=third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html

Committed: https://crrev.com/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6
Cr-Commit-Position: refs/heads/master@{#405066}
==========

[commit-bot: I haz the power, 2016-07-13 07:16:57]

Patchset 4 (id:??) landed as
https://crrev.com/c35147b9b40980dcaa3fbe64aa355d461a7e6bd6
Cr-Commit-Position: refs/heads/master@{#405066}