third_party/WebKit/Source/core/layout/LayoutMenuList.cpp - Issue 2131303003: Do not use the fixed height for HTML select element if appearance is none.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

Issue 2131303003: Do not use the fixed height for HTML select element if appearance is none. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 3rd rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp b/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

index af5a325320d06d0f4df1d2dccd644c7f838f081e..842318f5db836237b6569f3b770afbefdf36a431 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

@@ -263,7 +263,8 @@ void LayoutMenuList::computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth,

void LayoutMenuList::computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop,

LogicalExtentComputedValues& computedValues) const

{

- logicalHeight = m_innerBlockHeight + borderAndPaddingHeight();

+ if (style()->hasAppearance())

+ logicalHeight = m_innerBlockHeight + borderAndPaddingHeight();

LayoutBox::computeLogicalHeight(logicalHeight, logicalTop, computedValues);

}

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select/menulist-appearance-none.html ('k') | no next file » | no next file with comments »