Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2131283002: Use will-change: auto !important in fullscreen.css (Closed)

Created:
4 years, 5 months ago by foolip
Modified:
4 years, 5 months ago
Reviewers:
esprehn, eae
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use will-change: auto !important in fullscreen.css will-change: none doesn't actually work, and the original problem with http://output.jsbin.com/wimura was not fixed by https://codereview.chromium.org/1656713002 The test case is modified to match the original problem, so that this doesn't regress with the top layer rewrite. BUG=582318, 240576 R=eae@chromium.org,esprehn@chromium.org Committed: https://crrev.com/f136c2921cbebd92222e359a7dd04ef3b2b82307 Cr-Commit-Position: refs/heads/master@{#404851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M third_party/WebKit/LayoutTests/fullscreen/full-screen-will-change.html View 2 chunks +2 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/css/fullscreen.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
foolip
4 years, 5 months ago (2016-07-08 15:55:07 UTC) #1
eae
OK LGTM
4 years, 5 months ago (2016-07-12 16:35:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131283002/1
4 years, 5 months ago (2016-07-12 20:14:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 22:53:29 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 22:53:50 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 22:54:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f136c2921cbebd92222e359a7dd04ef3b2b82307
Cr-Commit-Position: refs/heads/master@{#404851}

Powered by Google App Engine
This is Rietveld 408576698