Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 1656713002: Add will-change: none !important to fullscreen.css (Closed)

Created:
4 years, 10 months ago by eae
Modified:
4 years, 10 months ago
Reviewers:
philipj_slow
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add will-change: none !important to fullscreen.css BUG=582318 R=philipj@opera.com Committed: https://crrev.com/de91548726641481621012dfd9e97daded039680 Cr-Commit-Position: refs/heads/master@{#372615}

Patch Set 1 #

Patch Set 2 : w/Test #

Patch Set 3 : Add missing -expected.html file #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --1 lines) Patch
A + third_party/WebKit/LayoutTests/fullscreen/full-screen-will-change.html View 1 1 chunk +1 line, -0 lines 1 comment Download
A + third_party/WebKit/LayoutTests/fullscreen/full-screen-will-change-expected.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/css/fullscreen.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
eae
4 years, 10 months ago (2016-02-01 02:18:31 UTC) #1
philipj_slow
LGTM. Maybe a test case in the style of full-screen-fixed-pos-parent.html to ensure that this doesn't ...
4 years, 10 months ago (2016-02-01 03:49:40 UTC) #2
eae
On 2016/02/01 03:49:40, philipj_UTC7 wrote: > LGTM. Maybe a test case in the style of ...
4 years, 10 months ago (2016-02-01 04:15:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656713002/40001
4 years, 10 months ago (2016-02-01 05:38:38 UTC) #6
philipj_slow
https://codereview.chromium.org/1656713002/diff/40001/third_party/WebKit/LayoutTests/fullscreen/full-screen-will-change.html File third_party/WebKit/LayoutTests/fullscreen/full-screen-will-change.html (right): https://codereview.chromium.org/1656713002/diff/40001/third_party/WebKit/LayoutTests/fullscreen/full-screen-will-change.html#newcode24 third_party/WebKit/LayoutTests/fullscreen/full-screen-will-change.html:24: will-change: transform; You probably don't need a test using ...
4 years, 10 months ago (2016-02-01 06:45:14 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-01 07:06:41 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 07:07:58 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/de91548726641481621012dfd9e97daded039680
Cr-Commit-Position: refs/heads/master@{#372615}

Powered by Google App Engine
This is Rietveld 408576698