android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java - Issue 213123011: Make DeviceDisplayInfo a Singleton and have ScreenOrientationListener update it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java

Issue 213123011: Make DeviceDisplayInfo a Singleton and have ScreenOrientationListener update it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java

index 41c457429640b06cd4d028ec651fec15d812cd09..f61263aab5309bfebadbc283b1c0c564ea96ecab 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java

@@ -41,7 +41,7 @@ public class AwLegacyQuirksTest extends AwTestBase {

settings.setJavaScriptEnabled(true);

DeviceDisplayInfo deviceInfo =

- DeviceDisplayInfo.create(getInstrumentation().getTargetContext());

+ DeviceDisplayInfo.getInstance(getInstrumentation().getTargetContext());

loadDataSync(awContents, onPageFinishedHelper, pageDeviceDpi, "text/html", false);

int actualWidth = Integer.parseInt(getTitleOnUiThread(awContents));

assertEquals(deviceInfo.getDisplayWidth(), actualWidth, 10f);