android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java - Issue 213123011: Make DeviceDisplayInfo a Singleton and have ScreenOrientationListener update it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java

Issue 213123011: Make DeviceDisplayInfo a Singleton and have ScreenOrientationListener update it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java

index 3ada155c7f510ca20844689492b6f45d76fad46e..2be57a526cb3040761218abb00821f3cb02d7295 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java

@@ -308,7 +308,7 @@ public class AndroidViewIntegrationTest extends AwTestBase {

assertZeroHeight(testContainerView);

final double deviceDIPScale =

- DeviceDisplayInfo.create(testContainerView.getContext()).getDIPScale();

+ DeviceDisplayInfo.getInstance(testContainerView.getContext()).getDIPScale();

final int contentWidthCss = 142;

final int contentHeightCss = 180;

@@ -336,7 +336,7 @@ public class AndroidViewIntegrationTest extends AwTestBase {

assertZeroHeight(testContainerView);

final double deviceDIPScale =

- DeviceDisplayInfo.create(testContainerView.getContext()).getDIPScale();

+ DeviceDisplayInfo.getInstance(testContainerView.getContext()).getDIPScale();

final int contentWidthCss = 142;

final int contentHeightCss = 180;

@@ -365,7 +365,7 @@ public class AndroidViewIntegrationTest extends AwTestBase {

final AwContents awContents = testContainerView.getAwContents();

final double deviceDIPScale =

- DeviceDisplayInfo.create(testContainerView.getContext()).getDIPScale();

+ DeviceDisplayInfo.getInstance(testContainerView.getContext()).getDIPScale();

final int physicalWidth = 600;

final int spanWidth = 42;

final int expectedWidthCss =