Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2130933002: 🎧 Initial version of Android Studio project generation (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initial version of Android Studio project generation This supports Java auto-completion, but probably not many more advanced features since it doesn't include resources, assets, etc. It also likely doesn't work for test apks yet (haven't tried it). Usage: build/android/generate_gradle.py \ --output-directory out/Default \ --target //chrome/android:chrome_public_apk \ --project-dir my-project-dir BUG=620034 Committed: https://crrev.com/0fa1a09f4f5418b05248c48e995ce7434970e6cc Cr-Commit-Position: refs/heads/master@{#405431}

Patch Set 1 #

Total comments: 28

Patch Set 2 : comments 1 #

Total comments: 13

Patch Set 3 : comments 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -4 lines) Patch
M build/android/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
M build/android/PRESUBMIT.py View 1 2 chunks +1 line, -1 line 0 comments Download
A build/android/gradle/build.gradle.jinja View 1 1 chunk +98 lines, -0 lines 0 comments Download
A build/android/gradle/generate_gradle.py View 1 2 1 chunk +386 lines, -0 lines 0 comments Download
M build/android/gyp/write_build_config.py View 2 chunks +15 lines, -2 lines 0 comments Download
M build/android/incremental_install/installer.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
agrieve
On 2016/07/07 20:46:43, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org
4 years, 5 months ago (2016-07-07 20:46:57 UTC) #3
jbudorick
Trying to think of a clean way that you could run this as its own ...
4 years, 5 months ago (2016-07-07 22:32:30 UTC) #4
agrieve
I actually had started off with this as a GN rule, but switched to a ...
4 years, 5 months ago (2016-07-08 19:07:29 UTC) #5
agrieve
On 2016/07/08 19:07:29, agrieve wrote: > I actually had started off with this as a ...
4 years, 5 months ago (2016-07-12 14:14:12 UTC) #7
jbudorick
https://codereview.chromium.org/2130933002/diff/20001/build/android/PRESUBMIT.py File build/android/PRESUBMIT.py (left): https://codereview.chromium.org/2130933002/diff/20001/build/android/PRESUBMIT.py#oldcode24 build/android/PRESUBMIT.py:24: r'incremental_install/.*\.py', Yay! https://codereview.chromium.org/2130933002/diff/20001/build/android/gradle/generate_gradle.py File build/android/gradle/generate_gradle.py (right): https://codereview.chromium.org/2130933002/diff/20001/build/android/gradle/generate_gradle.py#newcode21 build/android/gradle/generate_gradle.py:21: from ...
4 years, 5 months ago (2016-07-12 19:20:17 UTC) #8
agrieve
Thanks as always for your attention to detail! https://codereview.chromium.org/2130933002/diff/20001/build/android/gradle/generate_gradle.py File build/android/gradle/generate_gradle.py (right): https://codereview.chromium.org/2130933002/diff/20001/build/android/gradle/generate_gradle.py#newcode21 build/android/gradle/generate_gradle.py:21: from ...
4 years, 5 months ago (2016-07-13 14:09:08 UTC) #9
jbudorick
lgtm
4 years, 5 months ago (2016-07-13 14:33:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130933002/40001
4 years, 5 months ago (2016-07-13 18:17:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/103345)
4 years, 5 months ago (2016-07-13 20:45:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130933002/40001
4 years, 5 months ago (2016-07-14 03:27:17 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 04:03:34 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0fa1a09f4f5418b05248c48e995ce7434970e6cc
Cr-Commit-Position: refs/heads/master@{#405431}

Powered by Google App Engine
This is Rietveld 408576698