Chromium Code Reviews Chromium Code Reviews
Issue 2130933002:
🎧 Initial version of Android Studio project generation (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Presubmit script for android buildbot. | 5 """Presubmit script for android buildbot. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for |
| 8 details on the presubmit API built into depot_tools. | 8 details on the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| 11 | 11 |
| 12 def CommonChecks(input_api, output_api): | 12 def CommonChecks(input_api, output_api): |
| 13 output = [] | 13 output = [] |
| 14 | 14 |
| 15 build_android_dir = input_api.PresubmitLocalPath() | 15 build_android_dir = input_api.PresubmitLocalPath() |
| 16 | 16 |
| 17 def J(*dirs): | 17 def J(*dirs): |
| 18 """Returns a path relative to presubmit directory.""" | 18 """Returns a path relative to presubmit directory.""" |
| 19 return input_api.os_path.join(build_android_dir, *dirs) | 19 return input_api.os_path.join(build_android_dir, *dirs) |
| 20 | 20 |
| 21 build_pys = [ | 21 build_pys = [ |
| 22 r'gyp/.*\.py$', | 22 r'gyp/.*\.py$', |
| 23 r'gn/.*\.py', | 23 r'gn/.*\.py', |
| 24 r'incremental_install/.*\.py', | |
|
jbudorick
2016/07/12 19:20:17
Yay!
| |
| 25 ] | 24 ] |
| 26 output.extend(input_api.canned_checks.RunPylint( | 25 output.extend(input_api.canned_checks.RunPylint( |
| 27 input_api, | 26 input_api, |
| 28 output_api, | 27 output_api, |
| 29 pylintrc='pylintrc', | 28 pylintrc='pylintrc', |
| 30 black_list=build_pys, | 29 black_list=build_pys, |
| 31 extra_paths_list=[ | 30 extra_paths_list=[ |
| 32 J(), | 31 J(), |
| 32 J('gyp'), | |
| 33 J('buildbot'), | 33 J('buildbot'), |
| 34 J('..', '..', 'third_party', 'catapult', 'devil') | 34 J('..', '..', 'third_party', 'catapult', 'devil') |
| 35 ])) | 35 ])) |
| 36 output.extend(input_api.canned_checks.RunPylint( | 36 output.extend(input_api.canned_checks.RunPylint( |
| 37 input_api, | 37 input_api, |
| 38 output_api, | 38 output_api, |
| 39 white_list=build_pys, | 39 white_list=build_pys, |
| 40 extra_paths_list=[J('gyp'), J('gn')])) | 40 extra_paths_list=[J('gyp'), J('gn')])) |
| 41 | 41 |
| 42 # Disabled due to http://crbug.com/410936 | 42 # Disabled due to http://crbug.com/410936 |
| (...skipping 24 matching lines...) Expand all Loading... | |
| 67 | 67 |
| 68 return output | 68 return output |
| 69 | 69 |
| 70 | 70 |
| 71 def CheckChangeOnUpload(input_api, output_api): | 71 def CheckChangeOnUpload(input_api, output_api): |
| 72 return CommonChecks(input_api, output_api) | 72 return CommonChecks(input_api, output_api) |
| 73 | 73 |
| 74 | 74 |
| 75 def CheckChangeOnCommit(input_api, output_api): | 75 def CheckChangeOnCommit(input_api, output_api): |
| 76 return CommonChecks(input_api, output_api) | 76 return CommonChecks(input_api, output_api) |
| OLD | NEW |
