Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2130903002: Make all parameters reqiured to GrReducedClip::ReduceClipStack (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@hidebounds
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make all parameters reqiured to GrReducedClip::ReduceClipStack GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130903002 Committed: https://skia.googlesource.com/skia/+/00ee2a8482e1b910658606d1643324634ffc1ed0

Patch Set 1 #

Patch Set 2 : restore whitespace #

Total comments: 2

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -78 lines) Patch
M src/gpu/GrReducedClip.h View 1 chunk +7 lines, -12 lines 0 comments Download
M src/gpu/GrReducedClip.cpp View 1 2 4 chunks +22 lines, -40 lines 0 comments Download
M tests/ClipStackTest.cpp View 1 9 chunks +17 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bsalomon
This didn't remove as much as I hoped, but still seems worth landing.
4 years, 5 months ago (2016-07-07 20:18:50 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2130903002/diff/20001/src/gpu/GrReducedClip.cpp File src/gpu/GrReducedClip.cpp (right): https://codereview.chromium.org/2130903002/diff/20001/src/gpu/GrReducedClip.cpp#newcode362 src/gpu/GrReducedClip.cpp:362: *tighterBounds = queryBounds; missing ' ' ?
4 years, 5 months ago (2016-07-07 20:30:48 UTC) #4
bsalomon
https://codereview.chromium.org/2130903002/diff/20001/src/gpu/GrReducedClip.cpp File src/gpu/GrReducedClip.cpp (right): https://codereview.chromium.org/2130903002/diff/20001/src/gpu/GrReducedClip.cpp#newcode362 src/gpu/GrReducedClip.cpp:362: *tighterBounds = queryBounds; On 2016/07/07 20:30:48, robertphillips wrote: > ...
4 years, 5 months ago (2016-07-07 23:53:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130903002/40001
4 years, 5 months ago (2016-07-07 23:53:17 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/00ee2a8482e1b910658606d1643324634ffc1ed0
4 years, 5 months ago (2016-07-08 10:28:41 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 10:28:44 UTC) #11
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698