Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: src/gpu/GrReducedClip.h

Issue 2130903002: Make all parameters reqiured to GrReducedClip::ReduceClipStack (Closed) Base URL: https://chromium.googlesource.com/skia.git@hidebounds
Patch Set: Address comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/GrReducedClip.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrReducedClip.h
diff --git a/src/gpu/GrReducedClip.h b/src/gpu/GrReducedClip.h
index 3a7c173d5ec06ee44267021fcb605f941f1622dc..da0bae6bfcd95340f2374d85577f14520cd7bbfb 100644
--- a/src/gpu/GrReducedClip.h
+++ b/src/gpu/GrReducedClip.h
@@ -26,24 +26,19 @@ public:
* full stack to the rectangle. The clip stack generation id that represents
* the list of elements is returned in resultGenID. The initial state of the
* query rectangle before the first clip element is applied is returned via
- * initialState. Optionally, the caller can request a tighter bounds on the
- * clip be returned via tighterBounds. If not nullptr, tighterBounds will
- * always be contained by queryBounds after return. If tighterBounds is
- * specified then it is assumed that the caller will implicitly clip against
- * it. If the caller specifies non-nullptr for requiresAA then it will indicate
- * whether anti-aliasing is required to process any of the elements in the
- * result.
- *
- * This may become a member function of SkClipStack when its interface is
- * determined to be stable.
+ * initialState. The reducer output tighterBounds is a tighter bounds on the
+ * clip. tighterBounds will always be contained by queryBounds after return.
+ * It is assumed that the caller will not draw outside of tighterBounds.
+ * The requiresAA output will indicate whether anti-aliasing is required to
+ * process any of the elements in the element list result.
*/
static void ReduceClipStack(const SkClipStack& stack,
const SkIRect& queryBounds,
ElementList* result,
int32_t* resultGenID,
InitialState* initialState,
- SkIRect* tighterBounds = nullptr,
- bool* requiresAA = nullptr);
+ SkIRect* tighterBounds,
+ bool* requiresAA);
};
#endif
« no previous file with comments | « no previous file | src/gpu/GrReducedClip.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698