Issue 2130873002: Use AddressRewriter when merging autofill profile addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2130873002: Use AddressRewriter when merging autofill profile addresses. (Closed)

Created:
4 years, 5 months ago by Roger McFarlane (Chromium)

Modified:
4 years, 5 months ago

Reviewers:
Mathieu, sebsg

CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use AddressRewriter when merging autofill profile addresses. This CL applies the appropriate AddressRewriter when comparing autofill profile address fields during merge. The fields were already been rewritten when comparing to see if a merge was possible, but this wasn't being done when carrying out the actual merge. R=mathp@chromium.org, sebsg@chromium.org BUG=618095

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -6 lines)			Patch
	M	components/autofill/core/browser/autofill_profile_comparator.cc	View		3 chunks	+12 lines, -6 lines	0 comments	Download
	M	components/autofill/core/browser/autofill_profile_comparator_unittest.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Roger McFarlane (Chromium)

4 years, 5 months ago (2016-07-08 14:35:49 UTC) #3

Moved to https://codereview.chromium.org/2137533002

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages