Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5345)

Unified Diff: chrome/common/chrome_content_client.cc

Issue 2130803003: Rearrange Flash component registration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Keep using chrome_content_client to load bundled Flash Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/component_updater/pepper_flash_component_installer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_content_client.cc
diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc
index 57355af2b5fb25e83a2c12238619c9daf1de2928..da7909d5009c678e8b4fd39212c98d40ea0397a5 100644
--- a/chrome/common/chrome_content_client.cc
+++ b/chrome/common/chrome_content_client.cc
@@ -340,6 +340,12 @@ bool GetComponentUpdatedPepperFlash(content::PepperPluginInfo* plugin) {
}
#endif // defined(OS_LINUX)
+// Similar to GetComponentUpdatedPepperFlash, this should be used on Linux only
+// because on other platforms the component updater can take responsibility for
+// locating and registering the bundled version of Flash.
+// However, a large number of tests depend upon having Flash registered
+// *synchronously* during browser startup.
+// TODO(waffles): Fix those tests and then compile / run this only on Linux.
bool GetBundledPepperFlash(content::PepperPluginInfo* plugin) {
#if defined(FLAPPER_AVAILABLE)
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
« no previous file with comments | « chrome/browser/component_updater/pepper_flash_component_installer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698