Rearrange Flash component registration.

chrome/common/chrome_content_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_content_client.h"
 
 #include <stdint.h>
 
 #include <memory>
 #include <tuple>
@@ skipping 322 matching lines @@
       return true;
     }
     LOG(ERROR)
         << "Failed to locate and load the component updated flash plugin.";
   }
 #endif  // defined(FLAPPER_AVAILABLE)
   return false;
 }
 #endif  // defined(OS_LINUX)
 
+// Similar to GetComponentUpdatedPepperFlash, this should be used on Linux only
+// because on other platforms the component updater can take responsibility for
+// locating and registering the bundled version of Flash.
+// However, a large number of tests depend upon having Flash registered
+// *synchronously* during browser startup.
+// TODO(waffles): Fix those tests and then compile / run this only on Linux.
 bool GetBundledPepperFlash(content::PepperPluginInfo* plugin) {
 #if defined(FLAPPER_AVAILABLE)
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
 
   // Ignore bundled Pepper Flash if there is Pepper Flash specified from the
   // command-line.
   if (command_line->HasSwitch(switches::kPpapiFlashPath))
     return false;
 
   bool force_disable =
@@ skipping 359 matching lines @@
     origin_trial_policy_ = base::WrapUnique(new ChromeOriginTrialPolicy());
   }
   return origin_trial_policy_.get();
 }
 
 #if defined(OS_ANDROID)
 media::MediaClientAndroid* ChromeContentClient::GetMediaClientAndroid() {
   return new ChromeMediaClientAndroid();
 }
 #endif  // OS_ANDROID