Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 213073002: Further WTF::copyChars simplification (Closed)

Created:
6 years, 9 months ago by Mikhail
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Further WTF::copyChars simplification This patch removes the code branch handling "numCharacters == 1" case leaving only the 'memcpy' call inside the 'WTF::copyChars' function's body. The reason for it is that the branch made the code more complex giving the minor performance benefit: there was no benefit if the 'source' arg was static, otherwise the difference was just two extra asm calls ('testq' and 'je') which should not give impact to the real use cases performance (tested with GCC 4.6.3). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/wtf/text/StringImpl.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Mikhail
PTAL
6 years, 9 months ago (2014-03-26 15:58:31 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-26 16:49:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
6 years, 9 months ago (2014-03-26 16:49:29 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 16:52:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-26 16:52:43 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-26 16:58:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
6 years, 9 months ago (2014-03-26 16:58:41 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 17:07:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-26 17:07:46 UTC) #9
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 9 months ago (2014-03-27 09:03:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
6 years, 9 months ago (2014-03-27 09:03:32 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 10:13:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 10:13:34 UTC) #13
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 9 months ago (2014-03-27 10:32:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
6 years, 9 months ago (2014-03-27 10:32:37 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 11:50:03 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 11:50:04 UTC) #17
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 8 months ago (2014-03-27 14:10:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
6 years, 8 months ago (2014-03-27 14:10:43 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 14:50:55 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-03-27 14:50:56 UTC) #21
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 8 months ago (2014-03-27 15:17:01 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
6 years, 8 months ago (2014-03-27 15:17:07 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 15:36:37 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-03-27 15:36:38 UTC) #25
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 8 months ago (2014-03-28 07:49:27 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
6 years, 8 months ago (2014-03-28 07:49:36 UTC) #27
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 08:56:57 UTC) #28
Message was sent while issue was closed.
Change committed as 170299

Powered by Google App Engine
This is Rietveld 408576698