|
|
Created:
6 years, 9 months ago by Mikhail Modified:
6 years, 8 months ago Reviewers:
abarth-chromium CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Visibility:
Public. |
DescriptionFurther WTF::copyChars simplification
This patch removes the code branch handling "numCharacters == 1"
case leaving only the 'memcpy' call inside the 'WTF::copyChars'
function's body.
The reason for it is that the branch made the code more complex
giving the minor performance benefit: there was no benefit if the
'source' arg was static, otherwise the difference was just two
extra asm calls ('testq' and 'je') which should not give impact
to the real use cases performance (tested with GCC 4.6.3).
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170299
Patch Set 1 #
Messages
Total messages: 28 (0 generated)
PTAL
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on blink_presubmit
The CQ bit was checked by abarth@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by mikhail.pozdnyakov@intel.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by mikhail.pozdnyakov@intel.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by mikhail.pozdnyakov@intel.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by mikhail.pozdnyakov@intel.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by mikhail.pozdnyakov@intel.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/213073002/1
Message was sent while issue was closed.
Change committed as 170299 |