Source/wtf/text/StringImpl.h - Issue 213073002: Further WTF::copyChars simplification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/text/StringImpl.h

Issue 213073002: Further WTF::copyChars simplification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/wtf/text/StringImpl.h

diff --git a/Source/wtf/text/StringImpl.h b/Source/wtf/text/StringImpl.h

index afc6d95aab8b704fb55085ac36e94c941e2ea468..727c6d98cfc81cdb11a9a6d4ca39241c1e6d5f46 100644

--- a/Source/wtf/text/StringImpl.h

+++ b/Source/wtf/text/StringImpl.h

@@ -295,11 +295,6 @@ public:

// FIXME: Does this really belong in StringImpl?

template <typename T> static void copyChars(T* destination, const T* source, unsigned numCharacters)

{

- if (numCharacters == 1) {

- *destination = *source;

- return;

- }

memcpy(destination, source, numCharacters * sizeof(T));

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »