Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2130673002: Avoid invoking ResourceFetcher::cachedResource() with a null URL (Closed)

Created:
4 years, 5 months ago by alancutter (OOO until 2018)
Modified:
4 years, 5 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid invoking ResourceFetcher::cachedResource() with a null URL Invalid CSS image URLs end up with a null m_absoluteURL internally. ResourceFetcher::cachedResource() cannot deal with null URLs so check before calling it. BUG=622703 Committed: https://crrev.com/2b4803484f5e55299bf6f5ea1bd95639f88e75b1 Cr-Commit-Position: refs/heads/master@{#404111}

Patch Set 1 #

Patch Set 2 : Added test case #

Patch Set 3 : semicolon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/tables/invalid-background-url-crash.html View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageValue.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
alancutter (OOO until 2018)
4 years, 5 months ago (2016-07-07 05:36:22 UTC) #2
Timothy Loh
On 2016/07/07 05:36:22, alancutter wrote: Test?
4 years, 5 months ago (2016-07-07 05:41:11 UTC) #4
alancutter (OOO until 2018)
On 2016/07/07 at 05:41:11, timloh wrote: > On 2016/07/07 05:36:22, alancutter wrote: > > Test? ...
4 years, 5 months ago (2016-07-07 05:42:04 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130673002/40001
4 years, 5 months ago (2016-07-07 05:43:17 UTC) #7
Timothy Loh
On 2016/07/07 05:42:04, alancutter wrote: > On 2016/07/07 at 05:41:11, timloh wrote: > > On ...
4 years, 5 months ago (2016-07-07 05:44:47 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/251271)
4 years, 5 months ago (2016-07-07 07:47:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130673002/40001
4 years, 5 months ago (2016-07-07 08:23:55 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-07 09:22:51 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 09:22:59 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 09:25:25 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2b4803484f5e55299bf6f5ea1bd95639f88e75b1
Cr-Commit-Position: refs/heads/master@{#404111}

Powered by Google App Engine
This is Rietveld 408576698