third_party/WebKit/Source/core/css/CSSImageValue.cpp - Issue 2130673002: Avoid invoking ResourceFetcher::cachedResource() with a null URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSImageValue.cpp

Issue 2130673002: Avoid invoking ResourceFetcher::cachedResource() with a null URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: semicolon Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/CSSImageValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSImageValue.cpp b/third_party/WebKit/Source/core/css/CSSImageValue.cpp

index 076639a9d0d09a4e8429195090b191b9dc4f39b6..074de6916f273e87ef2abf6ba2258986d2ba3675 100644

--- a/third_party/WebKit/Source/core/css/CSSImageValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSImageValue.cpp

@@ -80,7 +80,7 @@ StyleImage* CSSImageValue::cacheImage(Document* document, CrossOriginAttributeVa

void CSSImageValue::restoreCachedResourceIfNeeded(Document& document) const

{

- if (m_isCachePending || !m_cachedImage || !document.fetcher())

+ if (m_isCachePending || !m_cachedImage || !document.fetcher() || m_absoluteURL.isNull())

return;

if (document.fetcher()->cachedResource(KURL(ParsedURLString, m_absoluteURL)))

return;

« no previous file with comments | « third_party/WebKit/LayoutTests/tables/invalid-background-url-crash.html ('k') | no next file » | no next file with comments »