Teach HistoryItem about a request's initiator.

Teach HistoryItem about a request's initiator.

Currently, we don't store enough information on HistoryItem to deal
correctly with 'SameSite' cookies for cases in which the user navigates
their history. This patch adds the initiator of the original request to
the HistoryItem, and restores it as part of the navigation work in
FrameLoader.

BUG=626243
R=yoav@yoav.ws

Committed: https://crrev.com/c19960b67391c5789878f475163b813ad9daf994
Cr-Commit-Position: refs/heads/master@{#404123}

[Mike West, 2016-07-07 07:59:24]

yoav@: Mind taking a look at this?

[Mike West, 2016-07-07 08:23:39]

Description was changed from

==========
Teach HistoryItem about a request's initiator.

Currently, we don't store enough information on HistoryItem to deal
correctly with 'SameSite' cookies for cases in which the user navigates
their history. This patch adds the initiator of the original request to
the HistoryItem, and restores it as part of the navigation work in
FrameLoader.

BUG=619603
R=yoav@yoav.ws
==========

to

==========
Teach HistoryItem about a request's initiator.

Currently, we don't store enough information on HistoryItem to deal
correctly with 'SameSite' cookies for cases in which the user navigates
their history. This patch adds the initiator of the original request to
the HistoryItem, and restores it as part of the navigation work in
FrameLoader.

BUG=626243
R=yoav@yoav.ws
==========

[Yoav Weiss, 2016-07-07 08:24:03]

On 2016/07/07 07:59:24, Mike West wrote:
> yoav@: Mind taking a look at this?

LGTM

[Mike West, 2016-07-07 09:19:25]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2016-07-07 09:19:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 10:54:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-07 10:56:37]

Description was changed from

==========
Teach HistoryItem about a request's initiator.

Currently, we don't store enough information on HistoryItem to deal
correctly with 'SameSite' cookies for cases in which the user navigates
their history. This patch adds the initiator of the original request to
the HistoryItem, and restores it as part of the navigation work in
FrameLoader.

BUG=626243
R=yoav@yoav.ws
==========

to

==========
Teach HistoryItem about a request's initiator.

Currently, we don't store enough information on HistoryItem to deal
correctly with 'SameSite' cookies for cases in which the user navigates
their history. This patch adds the initiator of the original request to
the HistoryItem, and restores it as part of the navigation work in
FrameLoader.

BUG=626243
R=yoav@yoav.ws

Committed: https://crrev.com/c19960b67391c5789878f475163b813ad9daf994
Cr-Commit-Position: refs/heads/master@{#404123}
==========

[commit-bot: I haz the power, 2016-07-07 10:56:38]

Patchset 2 (id:??) landed as
https://crrev.com/c19960b67391c5789878f475163b813ad9daf994
Cr-Commit-Position: refs/heads/master@{#404123}

[Charlie Reis, 2016-07-07 22:03:51]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2016-07-07 22:03:52]

This broke the Site Isolation FYI bot, which started failing the
popup-cross-site.html test:
https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/b...

Also, I don't understand how this works.  We serialize HistoryItems into
PageState for NavigationEntries, and we write those to disk.  There doesn't seem
to be anything updating that serialization here, and it's non-trivial to do so.

I'm going to revert until we get a chance to discuss.  (Sorry!)

[Charlie Reis, 2016-07-07 22:08:01]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2124143005/ by creis@chromium.org.

The reason for reverting is: Failing on Site Isolation Linux FYI bot:
https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/b...

Also appears to have problems with restored session history items..