Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2125263002: Explicitly set a requestor origin when calling into WebLocalFrame::loadRequest (Closed)

Created:
4 years, 5 months ago by Mike West
Modified:
4 years, 5 months ago
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly set a requestor origin when calling into WebLocalFrame::loadRequest Various tests (and, in particular, the testrunner itself) use loadRequest as a shortcut around various bits of the loading infrastructure. This patch has zero web-visible impact, but will ensure that the DCHECK I'd like to add in https://codereview.chromium.org/2128503002 doesn't cause most tests to explode. BUG=625969 R=jochen@chromium.org Committed: https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb Cr-Commit-Position: refs/heads/master@{#404135}

Patch Set 1 #

Patch Set 2 : compile. #

Patch Set 3 : blink:: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M chrome/renderer/net/net_error_helper.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
Mike West
Would you mind stamping this, Jochen? It's a very small change indeed, and shouldn't have ...
4 years, 5 months ago (2016-07-07 09:59:41 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-07 11:08:18 UTC) #2
Mike West
On 2016/07/07 at 11:08:18, jochen wrote: > lgtm Thanks! I think I've even fixed the ...
4 years, 5 months ago (2016-07-07 11:15:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125263002/40001
4 years, 5 months ago (2016-07-07 11:16:09 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-07 12:32:12 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 12:32:14 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 12:33:46 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe9c3e778fcdeedaedd3dbd96d6f2b30f12fb6eb
Cr-Commit-Position: refs/heads/master@{#404135}

Powered by Google App Engine
This is Rietveld 408576698