Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2130543003: Convert some flexbox tests to testharness.js (Closed)

Created:
4 years, 5 months ago by cbiesinger
Modified:
4 years, 5 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert some flexbox tests to testharness.js R=eae@chromium.org,dgrogan@chromium.org Committed: https://crrev.com/e2276c4abe46c25480470c3f6d6b968671a8a4df Cr-Commit-Position: refs/heads/master@{#404835}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -98 lines) Patch
M third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html View 2 chunks +5 lines, -3 lines 2 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/box-orient-button.html View 1 chunk +4 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/flexbox/box-orient-button-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/display-flexbox-set-get.html View 1 chunk +17 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/flexbox/display-flexbox-set-get-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/flex-flow-initial.html View 1 chunk +8 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/flexbox/flex-flow-initial-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/flexitem-no-margin-collapsing.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/mainAxisExtent-crash.html View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/mainAxisExtent-crash-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/min-size-auto.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/overflow-keep-scrollpos.html View 2 chunks +5 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/flexbox/overflow-keep-scrollpos-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/resources/box-orient-button.js View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
cbiesinger
4 years, 5 months ago (2016-07-07 00:37:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130543003/1
4 years, 5 months ago (2016-07-07 00:38:12 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 03:47:41 UTC) #5
eae
LGTM w/nit https://codereview.chromium.org/2130543003/diff/1/third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html File third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html (right): https://codereview.chromium.org/2130543003/diff/1/third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html#newcode148 third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html:148: test(function() { Shouldn't the for in loop ...
4 years, 5 months ago (2016-07-12 16:56:54 UTC) #6
cbiesinger
https://codereview.chromium.org/2130543003/diff/1/third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html File third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html (right): https://codereview.chromium.org/2130543003/diff/1/third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html#newcode148 third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html:148: test(function() { On 2016/07/12 16:56:54, eae wrote: > Shouldn't ...
4 years, 5 months ago (2016-07-12 17:46:13 UTC) #7
eae
Ah, I assumed each assert would get a pass line (like they do for FAIL ...
4 years, 5 months ago (2016-07-12 17:49:56 UTC) #8
cbiesinger
On 2016/07/12 17:49:56, eae wrote: > Ah, I assumed each assert would get a pass ...
4 years, 5 months ago (2016-07-12 19:00:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130543003/1
4 years, 5 months ago (2016-07-12 19:03:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/189580) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 19:46:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130543003/1
4 years, 5 months ago (2016-07-12 19:48:59 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 21:20:10 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 21:21:14 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 21:21:50 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2276c4abe46c25480470c3f6d6b968671a8a4df
Cr-Commit-Position: refs/heads/master@{#404835}

Powered by Google App Engine
This is Rietveld 408576698