Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html

Issue 2130543003: Convert some flexbox tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/css3/flexbox/box-orient-button.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html
diff --git a/third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html b/third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html
index 345ce2c8987aa4f3dc35177ad2247a6f808219e8..cbbc97eb7aba4f10628163ec357e58571530f1da 100644
--- a/third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html
+++ b/third_party/WebKit/LayoutTests/css3/flexbox/align-absolute-child.html
@@ -59,7 +59,6 @@ body {
}
</style>
-<script src="../../resources/js-test.js"></script>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../../resources/check-layout-th.js"></script>
@@ -145,8 +144,11 @@ document.querySelector('.flexbox').style.height = '101px';
var afterPosition = absolute.getBoundingClientRect();
// Positioned element should not change position when the height of it's parent flexbox is changed.
-for (key in beforePosition)
- shouldBe('beforePosition[key]', 'afterPosition[key]');
+for (key in beforePosition) {
+ test(function() {
eae 2016/07/12 16:56:54 Shouldn't the for in loop be inside the test funci
cbiesinger 2016/07/12 17:46:13 I liked having one PASS line for each iteration of
+ assert_equals(beforePosition[key], afterPosition[key]);
+ }, 'position of ' + key);
+}
</script>
</body>
</html>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/css3/flexbox/box-orient-button.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698