Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2130453003: cert_verify_tool: Verify using the new pathbuilder too. (Closed)

Created:
4 years, 5 months ago by mattm
Modified:
4 years, 5 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cert-parsing-path-building
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cert_verify_tool: Verify using the new pathbuilder too. BUG=167789, 410574 Committed: https://crrev.com/3c66edcc05b447b2e26fbc87a84edf68d1bfac5c Cr-Commit-Position: refs/heads/master@{#405313}

Patch Set 1 #

Total comments: 13

Patch Set 2 : changes for comment #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -10 lines) Patch
M net/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/cert_verify_tool/cert_verify_tool.cc View 1 4 chunks +34 lines, -4 lines 0 comments Download
A + net/tools/cert_verify_tool/verify_using_path_builder.h View 1 chunk +7 lines, -6 lines 0 comments Download
A net/tools/cert_verify_tool/verify_using_path_builder.cc View 1 chunk +192 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (5 generated)
mattm
Followup to 1923433002.
4 years, 5 months ago (2016-07-06 20:43:19 UTC) #2
eroman
lgtm https://codereview.chromium.org/2130453003/diff/1/net/tools/cert_verify_tool/cert_verify_tool.cc File net/tools/cert_verify_tool/cert_verify_tool.cc (right): https://codereview.chromium.org/2130453003/diff/1/net/tools/cert_verify_tool/cert_verify_tool.cc#newcode29 net/tools/cert_verify_tool/cert_verify_tool.cc:29: std::cerr << " Use <localtime> instead of the ...
4 years, 5 months ago (2016-07-07 00:07:19 UTC) #3
mattm
https://codereview.chromium.org/2130453003/diff/1/net/tools/cert_verify_tool/cert_verify_tool.cc File net/tools/cert_verify_tool/cert_verify_tool.cc (right): https://codereview.chromium.org/2130453003/diff/1/net/tools/cert_verify_tool/cert_verify_tool.cc#newcode29 net/tools/cert_verify_tool/cert_verify_tool.cc:29: std::cerr << " Use <localtime> instead of the current ...
4 years, 5 months ago (2016-07-07 00:49:55 UTC) #4
eroman
lgtm https://codereview.chromium.org/2130453003/diff/1/net/tools/cert_verify_tool/cert_verify_tool.cc File net/tools/cert_verify_tool/cert_verify_tool.cc (right): https://codereview.chromium.org/2130453003/diff/1/net/tools/cert_verify_tool/cert_verify_tool.cc#newcode112 net/tools/cert_verify_tool/cert_verify_tool.cc:112: if (!time_flag.empty() || !utctime_flag.empty()) { On 2016/07/07 00:49:55, ...
4 years, 5 months ago (2016-07-07 01:21:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130453003/20001
4 years, 5 months ago (2016-07-07 22:10:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/32869)
4 years, 5 months ago (2016-07-07 22:19:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130453003/20001
4 years, 5 months ago (2016-07-13 20:59:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 22:40:58 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 22:41:08 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 22:43:40 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c66edcc05b447b2e26fbc87a84edf68d1bfac5c
Cr-Commit-Position: refs/heads/master@{#405313}

Powered by Google App Engine
This is Rietveld 408576698