Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2130203002: [DevTools] Better ExceptionDetails in js_protocol.json (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Better ExceptionDetails in js_protocol.json - line/column -> lineNumber/columnNumber - lineNumber is 0-based - ExceptionDetails is hidden - fixed +/-1 error R=dgozman@chromium.org BUG=591496 Committed: https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7 Cr-Commit-Position: refs/heads/master@{#404564}

Patch Set 1 #

Patch Set 2 : Fixed test #

Total comments: 5

Patch Set 3 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -14 lines) Patch
A third_party/WebKit/LayoutTests/inspector-protocol/console/console-line-and-column.html View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/console/console-line-and-column-expected.txt View 1 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.html View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/js_protocol.json View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 34 (17 generated)
kozy
Dmitry, please take a look!
4 years, 5 months ago (2016-07-08 01:29:54 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2130203002/diff/20001/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt (right): https://codereview.chromium.org/2130203002/diff/20001/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt#newcode3 third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt:3: 0:13 [Error] Uncaught SyntaxError: Unexpected identifier Is this ...
4 years, 5 months ago (2016-07-08 20:28:20 UTC) #3
kozy
all done https://codereview.chromium.org/2130203002/diff/20001/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt (right): https://codereview.chromium.org/2130203002/diff/20001/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt#newcode3 third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt:3: 0:13 [Error] Uncaught SyntaxError: Unexpected identifier On ...
4 years, 5 months ago (2016-07-08 20:44:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130203002/40001
4 years, 5 months ago (2016-07-08 20:44:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/252401)
4 years, 5 months ago (2016-07-08 22:14:06 UTC) #9
kozy
https://codereview.chromium.org/2130203002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js File third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js (right): https://codereview.chromium.org/2130203002/diff/20001/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js#newcode75 third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js:75: this._compilationFinishedForTest(); On 2016/07/08 20:44:00, kozyatinskiy wrote: > On 2016/07/08 ...
4 years, 5 months ago (2016-07-08 22:17:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130203002/20001
4 years, 5 months ago (2016-07-08 22:18:27 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/259530)
4 years, 5 months ago (2016-07-08 23:43:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130203002/60001
4 years, 5 months ago (2016-07-09 00:10:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130203002/60001
4 years, 5 months ago (2016-07-09 04:27:59 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-09 04:37:57 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130203002/60001
4 years, 5 months ago (2016-07-09 15:01:49 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on ...
4 years, 5 months ago (2016-07-09 17:02:18 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130203002/60001
4 years, 5 months ago (2016-07-09 17:31:15 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-07-09 18:03:27 UTC) #31
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-09 18:03:29 UTC) #32
commit-bot: I haz the power
4 years, 5 months ago (2016-07-09 18:05:32 UTC) #34
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7
Cr-Commit-Position: refs/heads/master@{#404564}

Powered by Google App Engine
This is Rietveld 408576698