third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html - Issue 2130203002: [DevTools] Better ExceptionDetails in js_protocol.json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

Issue 2130203002: [DevTools] Better ExceptionDetails in js_protocol.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

index 1378028f84091fe893733ad571f9c5151819493b..b1f7ca4b0a3b27dca84ee66a46529cb282f44c82 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

@@ -9,7 +9,7 @@ var test = function()

{

InspectorTest.addResult("exceptionDetails:")

InspectorTest.addResult(" " + exceptionDetails.text);

- InspectorTest.addResult(" line: " + exceptionDetails.line + ", column: " + exceptionDetails.column);

+ InspectorTest.addResult(" line: " + exceptionDetails.lineNumber + ", column: " + exceptionDetails.columnNumber);

var stack = exceptionDetails.stack ? exceptionDetails.stack.callFrames : null;

if (!stack) {

@@ -19,7 +19,7 @@ var test = function()

for (var i = 0; i < stack.length && i < 100; ++i) {

InspectorTest.addResult(" url: " + stack[i].url);

InspectorTest.addResult(" function: " + stack[i].functionName);

- InspectorTest.addResult(" line: " + stack[i].lineNumber);

+ InspectorTest.addResult(" line: " + stack[i].lineNumber);

}