Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 21302002: Fix a crash when running MediaGalleriesDialogControllerTest.TestNameGeneration on Swarm. (Closed)

Created:
7 years, 4 months ago by Lei Zhang
Modified:
7 years, 4 months ago
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock
Visibility:
Public.

Description

Fix a crash when running MediaGalleriesDialogControllerTest.TestNameGeneration on Swarm. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214741

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M chrome/browser/media_galleries/media_galleries_dialog_controller_unittest.cc View 3 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Probably worked outside of Swarm because some other test previously installed a StorageMonitor.
7 years, 4 months ago (2013-07-30 22:26:57 UTC) #1
vandebo (ex-Chrome)
LGTM
7 years, 4 months ago (2013-07-30 22:28:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/21302002/1
7 years, 4 months ago (2013-07-30 23:07:28 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 14:57:59 UTC) #4
Message was sent while issue was closed.
Change committed as 214741

Powered by Google App Engine
This is Rietveld 408576698