Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: chrome/browser/media_galleries/media_galleries_dialog_controller_unittest.cc

Issue 21302002: Fix a crash when running MediaGalleriesDialogControllerTest.TestNameGeneration on Swarm. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_path.h" 5 #include "base/files/file_path.h"
6 #include "base/strings/string16.h" 6 #include "base/strings/string16.h"
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/media_galleries/media_galleries_dialog_controller.h" 9 #include "chrome/browser/media_galleries/media_galleries_dialog_controller.h"
10 #include "chrome/browser/media_galleries/media_galleries_preferences.h" 10 #include "chrome/browser/media_galleries/media_galleries_preferences.h"
11 #include "chrome/browser/storage_monitor/storage_info.h" 11 #include "chrome/browser/storage_monitor/storage_info.h"
12 #include "chrome/browser/storage_monitor/test_storage_monitor.h"
12 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
13 14
14 std::string GalleryName(const chrome::MediaGalleryPrefInfo& gallery) { 15 namespace chrome {
16
17 std::string GalleryName(const MediaGalleryPrefInfo& gallery) {
15 string16 name = gallery.GetGalleryDisplayName(); 18 string16 name = gallery.GetGalleryDisplayName();
16 return UTF16ToASCII(name); 19 return UTF16ToASCII(name);
17 } 20 }
18 21
19 TEST(MediaGalleriesDialogControllerTest, TestNameGeneration) { 22 TEST(MediaGalleriesDialogControllerTest, TestNameGeneration) {
20 chrome::MediaGalleryPrefInfo gallery; 23 ASSERT_TRUE(test::TestStorageMonitor::CreateAndInstall());
24 MediaGalleryPrefInfo gallery;
21 gallery.pref_id = 1; 25 gallery.pref_id = 1;
22 gallery.device_id = chrome::StorageInfo::MakeDeviceId( 26 gallery.device_id = StorageInfo::MakeDeviceId(
23 chrome::StorageInfo::FIXED_MASS_STORAGE, "/path/to/gallery"); 27 StorageInfo::FIXED_MASS_STORAGE, "/path/to/gallery");
24 gallery.type = chrome::MediaGalleryPrefInfo::kAutoDetected; 28 gallery.type = MediaGalleryPrefInfo::kAutoDetected;
25 EXPECT_EQ("gallery", GalleryName(gallery)); 29 EXPECT_EQ("gallery", GalleryName(gallery));
26 30
27 gallery.display_name = ASCIIToUTF16("override"); 31 gallery.display_name = ASCIIToUTF16("override");
28 EXPECT_EQ("override", GalleryName(gallery)); 32 EXPECT_EQ("override", GalleryName(gallery));
29 33
30 gallery.display_name = string16(); 34 gallery.display_name = string16();
31 gallery.volume_label = ASCIIToUTF16("label"); 35 gallery.volume_label = ASCIIToUTF16("label");
32 EXPECT_EQ("gallery", GalleryName(gallery)); 36 EXPECT_EQ("gallery", GalleryName(gallery));
33 37
34 gallery.path = base::FilePath(FILE_PATH_LITERAL("sub/gallery2")); 38 gallery.path = base::FilePath(FILE_PATH_LITERAL("sub/gallery2"));
35 EXPECT_EQ("gallery2", GalleryName(gallery)); 39 EXPECT_EQ("gallery2", GalleryName(gallery));
36 40
37 gallery.path = base::FilePath(); 41 gallery.path = base::FilePath();
38 gallery.device_id = chrome::StorageInfo::MakeDeviceId( 42 gallery.device_id = StorageInfo::MakeDeviceId(
39 chrome::StorageInfo::REMOVABLE_MASS_STORAGE_WITH_DCIM, 43 StorageInfo::REMOVABLE_MASS_STORAGE_WITH_DCIM,
40 "/path/to/dcim"); 44 "/path/to/dcim");
41 gallery.display_name = ASCIIToUTF16("override"); 45 gallery.display_name = ASCIIToUTF16("override");
42 EXPECT_EQ("override", GalleryName(gallery)); 46 EXPECT_EQ("override", GalleryName(gallery));
43 47
44 gallery.volume_label = ASCIIToUTF16("volume"); 48 gallery.volume_label = ASCIIToUTF16("volume");
45 gallery.vendor_name = ASCIIToUTF16("vendor"); 49 gallery.vendor_name = ASCIIToUTF16("vendor");
46 gallery.model_name = ASCIIToUTF16("model"); 50 gallery.model_name = ASCIIToUTF16("model");
47 EXPECT_EQ("override", GalleryName(gallery)); 51 EXPECT_EQ("override", GalleryName(gallery));
48 52
49 gallery.display_name = string16(); 53 gallery.display_name = string16();
50 EXPECT_EQ("volume", GalleryName(gallery)); 54 EXPECT_EQ("volume", GalleryName(gallery));
51 55
52 gallery.volume_label = string16(); 56 gallery.volume_label = string16();
53 EXPECT_EQ("vendor, model", GalleryName(gallery)); 57 EXPECT_EQ("vendor, model", GalleryName(gallery));
54 58
55 gallery.total_size_in_bytes = 1000000; 59 gallery.total_size_in_bytes = 1000000;
56 EXPECT_EQ("977 KB vendor, model", GalleryName(gallery)); 60 EXPECT_EQ("977 KB vendor, model", GalleryName(gallery));
57 61
58 gallery.path = base::FilePath(FILE_PATH_LITERAL("sub/path")); 62 gallery.path = base::FilePath(FILE_PATH_LITERAL("sub/path"));
59 EXPECT_EQ("path - 977 KB vendor, model", GalleryName(gallery)); 63 EXPECT_EQ("path - 977 KB vendor, model", GalleryName(gallery));
60 } 64 }
65
66 } // namespace chrome
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698