Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2130183003: Remove bloat from SkBlend_opts. (Closed)

Created:
4 years, 5 months ago by herb_g
Modified:
4 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove bloat from SkBlend_opts. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130183003 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/2edf0c6a719b8dff4365628cf3b4481c5035f07a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -126 lines) Patch
M bench/SkBlend_optsBench.cpp View 6 chunks +71 lines, -24 lines 0 comments Download
M src/core/SkPM4fPriv.h View 1 chunk +24 lines, -0 lines 0 comments Download
M src/opts/SkBlend_opts.h View 4 chunks +16 lines, -85 lines 0 comments Download
M tests/SkBlend_optsTest.cpp View 4 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 25 (8 generated)
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-08 16:49:25 UTC) #4
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-08 17:00:58 UTC) #5
herb_g
I thought you wanted me to fix this. I would like to keep some of ...
4 years, 5 months ago (2016-07-08 17:07:57 UTC) #9
mtklein
It's okay with me if you want to keep more implementations as long as they're ...
4 years, 5 months ago (2016-07-11 13:48:51 UTC) #10
mtklein
or... land this now with my lgtm then I'll send you a CL for the ...
4 years, 5 months ago (2016-07-12 17:54:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130183003/1
4 years, 5 months ago (2016-07-12 18:15:44 UTC) #13
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-12 18:15:46 UTC) #14
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-12 18:31:20 UTC) #15
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-12 19:00:56 UTC) #16
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-12 19:31:18 UTC) #17
mtklein
Why isn't this landing?
4 years, 5 months ago (2016-07-12 19:32:10 UTC) #18
mtklein
On 2016/07/12 19:32:10, mtklein wrote: > Why isn't this landing? Duh, closed tree...
4 years, 5 months ago (2016-07-12 19:32:47 UTC) #19
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-12 20:01:16 UTC) #20
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-12 20:31:21 UTC) #21
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-12 21:01:25 UTC) #22
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-12 21:31:41 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 22:00:50 UTC) #25
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2edf0c6a719b8dff4365628cf3b4481c5035f07a

Powered by Google App Engine
This is Rietveld 408576698