Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2130133003: Remove flaky ShelfTooltipManagerTest.ShowTooltipWithDelay checks. (Closed)

Created:
4 years, 5 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove flaky ShelfTooltipManagerTest.ShowTooltipWithDelay checks. Flaked 7/16 of the last runs on Linux ChromiumOS Tests (1): http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ash_unittests&tests=ShelfTooltipManagerTest.ShowTooltipWithDelay BUG=NONE TEST=No/fewer flakes in this test fixture. R=jamescook@chromium.org Committed: https://crrev.com/32ab666012943cf3b40bfb77181c2b51bfbc969c Cr-Commit-Position: refs/heads/master@{#404460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M ash/shelf/shelf_tooltip_manager_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
msw
Hey James, please take a look; thanks!
4 years, 5 months ago (2016-07-08 17:44:10 UTC) #1
James Cook
lgtm
4 years, 5 months ago (2016-07-08 17:51:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130133003/1
4 years, 5 months ago (2016-07-08 17:56:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 19:23:03 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 19:24:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32ab666012943cf3b40bfb77181c2b51bfbc969c
Cr-Commit-Position: refs/heads/master@{#404460}

Powered by Google App Engine
This is Rietveld 408576698