Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2162)

Unified Diff: ash/shelf/shelf_tooltip_manager_unittest.cc

Issue 2130133003: Remove flaky ShelfTooltipManagerTest.ShowTooltipWithDelay checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_tooltip_manager_unittest.cc
diff --git a/ash/shelf/shelf_tooltip_manager_unittest.cc b/ash/shelf/shelf_tooltip_manager_unittest.cc
index b03eb96c054924b48f638c192559c54adc0e551f..d24fd793e846b662d8ea839176bc431bd28f3fb6 100644
--- a/ash/shelf/shelf_tooltip_manager_unittest.cc
+++ b/ash/shelf/shelf_tooltip_manager_unittest.cc
@@ -60,12 +60,7 @@ TEST_F(ShelfTooltipManagerTest, ShowTooltipWithDelay) {
tooltip_manager_->ShowTooltipWithDelay(shelf_->GetAppListButton());
EXPECT_FALSE(tooltip_manager_->IsVisible());
EXPECT_TRUE(IsTimerRunning());
- RunAllPendingInMessageLoop();
-#if !defined(OS_WIN)
- // This check fails on Windows.
- EXPECT_TRUE(tooltip_manager_->IsVisible());
-#endif // !OS_WIN
- EXPECT_FALSE(IsTimerRunning());
+ // TODO: Test that the delayed tooltip is shown, without flaky failures.
}
TEST_F(ShelfTooltipManagerTest, DoNotShowForInvalidView) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698