Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2130103002: Landing Recent QUIC changes until 2016-07-02 02:45 UTC (Closed)

Created:
4 years, 5 months ago by Buck
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 2016-07-02 02:45 UTC There are no flags to be updated. Reduce a LOG(WARNING) to a DLOG(WARNING). Merge internal change: 126469292 https://codereview.chromium.org/2131553002/ Add async variant of ProofSource::GetProof Merge internal change: 126468067 https://codereview.chromium.org/2125063003/ Require support for X509 certificates in QUIC CHLO PDMDs. Protected by --quic_require_x509 Merge internal change: 126463885 https://codereview.chromium.org/2126053003/ Allow WindowedFilter to use arbitrary time type instead of QuicTime. No functional change. Merge internal change: 126432842 https://codereview.chromium.org/2127153002/ Finish the comment in QuicWallTime. Merge internal change: 126423259 https://codereview.chromium.org/2131543002/ Use small_map instead of unordered_map for storing QUIC streams. Merge internal change: 126407199 https://codereview.chromium.org/2128253002/ Use overloaded operators with QuicTime for addition, subtraction and scalar multiplication. No functional change. This change removes Add, Subtract and Multiply methods from QuicTime and QuicTime::Delta and introduces the corresponding overloads for operators "+", "-" and "*". They behave in a manner that is "obvious, unsurprising, and consistent with the corresponding built-in operators". The goal here is to both to improve code readability, and to allow polymorphism between QuicTime and integral types in certain contexts. Merge internal change: 126407046 https://codereview.chromium.org/2125303002/ Deprecate --quic_sslr_limit_reduction. Merge internal change: 126352469 https://codereview.chromium.org/2124093002/ use std::unique_ptr for the callback argument of QUIC's ProofVerifier::Verify proof to make ownership clear. Merge internal change: 126331456 https://codereview.chromium.org/2126023002/ Change a LOG(WARNING) to a DLOG(WARNING). No functional change. Merge internal change: 126402784 https://codereview.chromium.org/2122313003/ Deprectate --quic_ignore_srbf Merge internal change: 126400472 https://codereview.chromium.org/2126903002/ refactor quic_dispatcher_test.cc to make test extensible. Merge internal change: 126327823 https://codereview.chromium.org/2128043002/ Downgrade entering/leaving batch mode log messages to DVLOG(2). Merge internal change: 126326347 https://codereview.chromium.org/2125163002/ Adds a DebugString method to QuicStreamSequencer. Merge internal change: 126205965 https://codereview.chromium.org/2129723002/ minor rearrangement of code only. No functional change intended, not flag-protected. Merge internal change: 126189095 https://codereview.chromium.org/2125993002/ Deprecate --quic_reply_to_rej. Merge internal change: 126102870 https://codereview.chromium.org/2129713002/ Adds a QuicUtil::HexDump method that provides better debug output of binary data. Example output: 48 65 6c 6c 6f 2c 20 51 55 49 43 21 20 54 68 69 |Hello, QUIC! Thi| 73 20 73 74 72 69 6e 67 20 73 68 6f 75 6c 64 20 |s string should | 62 65 20 6c 6f 6e 67 20 65 6e 6f 75 67 68 20 74 |be long enough t| 6f 20 73 70 61 6e 20 6d 75 6c 74 69 70 6c 65 20 |o span multiple | 6c 69 6e 65 73 20 6f 66 20 6f 75 74 70 75 74 2e |lines of output.| 01 02 03 04 |.... | Merge internal change: 126091835 https://codereview.chromium.org/2121293003/ Add a bool demand_x509_proof argument to QuicCryptoClientConfig::FillInchoateClientHello to conditionally add x509 related fields to QUIC CHLOs. Merge internal change: 126089643 https://codereview.chromium.org/2121383004/ Buffer undecryptable QUIC packets in the Dispatcher when doing cheap stateless rejects. Protected by --quic_use_cheap_stateless_rejects Merge internal change: 126002268 https://codereview.chromium.org/2128623002/ Deprecating --quic_cede_correctly Merge internal change: 125956747 https://codereview.chromium.org/2127983002/ BUG= R=rch@chromium.org Committed: https://crrev.com/6567aa52738a5be6b602aa6d25da0a1b730700c8 Cr-Commit-Position: refs/heads/master@{#404315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1072 lines, -817 lines) Patch
M net/quic/congestion_control/cubic.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/congestion_control/cubic_bytes.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/general_loss_algorithm.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/quic/congestion_control/general_loss_algorithm_test.cc View 14 chunks +28 lines, -28 lines 0 comments Download
M net/quic/congestion_control/hybrid_slow_start.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/hybrid_slow_start_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 4 chunks +7 lines, -11 lines 0 comments Download
M net/quic/congestion_control/pacing_sender_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/congestion_control/rtt_stats.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/congestion_control/rtt_stats.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M net/quic/congestion_control/rtt_stats_test.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 1 chunk +1 line, -6 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_simulator.cc View 6 chunks +13 lines, -14 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_base.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_bytes.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_bytes.cc View 2 chunks +1 line, -8 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_bytes_test.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_packets.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_packets.cc View 2 chunks +1 line, -8 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_packets_test.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M net/quic/congestion_control/windowed_filter.h View 6 chunks +29 lines, -19 lines 0 comments Download
M net/quic/congestion_control/windowed_filter_test.cc View 18 chunks +96 lines, -34 lines 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 24 chunks +26 lines, -2 lines 0 comments Download
M net/quic/crypto/proof_source.h View 5 chunks +45 lines, -4 lines 0 comments Download
M net/quic/crypto/proof_source_chromium.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_source_chromium.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_test.cc View 3 chunks +72 lines, -5 lines 0 comments Download
M net/quic/crypto/proof_verifier.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/proof_verifier_chromium.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 5 chunks +24 lines, -14 lines 0 comments Download
M net/quic/quic_alarm.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_alarm_test.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M net/quic/quic_buffered_packet_store.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quic_buffered_packet_store_test.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M net/quic/quic_chromium_alarm_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_chromium_alarm_factory_test.cc View 10 chunks +21 lines, -24 lines 0 comments Download
M net/quic/quic_chromium_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_chromium_packet_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_client_promised_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_client_session_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_clock.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/quic/quic_connection.cc View 13 chunks +23 lines, -24 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 35 chunks +51 lines, -51 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 4 chunks +7 lines, -18 lines 0 comments Download
M net/quic/quic_flags.h View 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/quic_flags.cc View 3 chunks +3 lines, -15 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_framer.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M net/quic/quic_framer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_headers_stream.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_protocol_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_received_packet_manager.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/quic/quic_received_packet_manager_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 6 chunks +11 lines, -20 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 14 chunks +17 lines, -90 lines 0 comments Download
M net/quic/quic_server_session_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_server_session_base_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_session.h View 4 chunks +14 lines, -7 lines 0 comments Download
M net/quic/quic_session.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_stream_sequencer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 3 chunks +14 lines, -1 line 0 comments Download
M net/quic/quic_sustained_bandwidth_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sustained_bandwidth_recorder_test.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_time.h View 5 chunks +48 lines, -33 lines 0 comments Download
M net/quic/quic_time_test.cc View 5 chunks +24 lines, -21 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_utils.h View 1 chunk +6 lines, -3 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +31 lines, -8 lines 0 comments Download
M net/quic/quic_utils_test.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/mock_clock.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client.h View 2 chunks +6 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 4 chunks +12 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 5 chunks +20 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 21 chunks +141 lines, -95 lines 0 comments Download
M net/tools/quic/quic_epoll_alarm_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_epoll_alarm_factory_test.cc View 4 chunks +16 lines, -19 lines 0 comments Download
M net/tools/quic/quic_epoll_clock.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/tools/quic/quic_epoll_clock_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_socket_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/stateless_rejector_test.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Buck
4 years, 5 months ago (2016-07-07 22:43:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130103002/1
4 years, 5 months ago (2016-07-07 22:44:31 UTC) #3
Ryan Hamilton
LGTM! I removed this blurb from the CL description: [ cloned from https://codereview.chromium.org/2132623002/ due to ...
4 years, 5 months ago (2016-07-07 22:45:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130103002/1
4 years, 5 months ago (2016-07-07 22:46:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/32888)
4 years, 5 months ago (2016-07-07 22:52:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130103002/1
4 years, 5 months ago (2016-07-07 22:56:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-08 00:47:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130103002/1
4 years, 5 months ago (2016-07-08 03:16:56 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 09:25:02 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 09:25:30 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 09:27:35 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6567aa52738a5be6b602aa6d25da0a1b730700c8
Cr-Commit-Position: refs/heads/master@{#404315}

Powered by Google App Engine
This is Rietveld 408576698