Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: net/quic/congestion_control/rtt_stats_test.cc

Issue 2130103002: Landing Recent QUIC changes until 2016-07-02 02:45 UTC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/congestion_control/rtt_stats.cc ('k') | net/quic/congestion_control/send_algorithm_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/rtt_stats_test.cc
diff --git a/net/quic/congestion_control/rtt_stats_test.cc b/net/quic/congestion_control/rtt_stats_test.cc
index 9a25946b2d0e783c0b080791784e492e694bf446..140288384deaee4c1eb99aec58fdccab87b5a6e9 100644
--- a/net/quic/congestion_control/rtt_stats_test.cc
+++ b/net/quic/congestion_control/rtt_stats_test.cc
@@ -78,29 +78,29 @@ TEST_F(RttStatsTest, MinRtt) {
rtt_stats_.WindowedMinRtt());
rtt_stats_.UpdateRtt(
QuicTime::Delta::FromMilliseconds(10), QuicTime::Delta::Zero(),
- QuicTime::Zero().Add(QuicTime::Delta::FromMilliseconds(10)));
+ QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(10));
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(10), rtt_stats_.min_rtt());
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(10), rtt_stats_.WindowedMinRtt());
rtt_stats_.UpdateRtt(
QuicTime::Delta::FromMilliseconds(50), QuicTime::Delta::Zero(),
- QuicTime::Zero().Add(QuicTime::Delta::FromMilliseconds(20)));
+ QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(20));
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(10), rtt_stats_.min_rtt());
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(10), rtt_stats_.WindowedMinRtt());
rtt_stats_.UpdateRtt(
QuicTime::Delta::FromMilliseconds(50), QuicTime::Delta::Zero(),
- QuicTime::Zero().Add(QuicTime::Delta::FromMilliseconds(30)));
+ QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(30));
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(10), rtt_stats_.min_rtt());
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(10), rtt_stats_.WindowedMinRtt());
rtt_stats_.UpdateRtt(
QuicTime::Delta::FromMilliseconds(50), QuicTime::Delta::Zero(),
- QuicTime::Zero().Add(QuicTime::Delta::FromMilliseconds(40)));
+ QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(40));
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(10), rtt_stats_.min_rtt());
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(10), rtt_stats_.WindowedMinRtt());
// Verify that ack_delay does not go into recording of min_rtt_.
rtt_stats_.UpdateRtt(
QuicTime::Delta::FromMilliseconds(7),
QuicTime::Delta::FromMilliseconds(2),
- QuicTime::Zero().Add(QuicTime::Delta::FromMilliseconds(50)));
+ QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(50));
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(7), rtt_stats_.min_rtt());
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(7), rtt_stats_.WindowedMinRtt());
}
@@ -132,21 +132,21 @@ TEST_F(RttStatsTest, ExpireSmoothedMetrics) {
EXPECT_EQ(initial_rtt, rtt_stats_.WindowedMinRtt());
EXPECT_EQ(initial_rtt, rtt_stats_.smoothed_rtt());
- EXPECT_EQ(initial_rtt.Multiply(0.5), rtt_stats_.mean_deviation());
+ EXPECT_EQ(0.5 * initial_rtt, rtt_stats_.mean_deviation());
// Update once with a 20ms RTT.
- QuicTime::Delta doubled_rtt = initial_rtt.Multiply(2);
+ QuicTime::Delta doubled_rtt = 2 * initial_rtt;
rtt_stats_.UpdateRtt(doubled_rtt, QuicTime::Delta::Zero(), QuicTime::Zero());
- EXPECT_EQ(initial_rtt.Multiply(1.125), rtt_stats_.smoothed_rtt());
+ EXPECT_EQ(1.125 * initial_rtt, rtt_stats_.smoothed_rtt());
// Expire the smoothed metrics, increasing smoothed rtt and mean deviation.
rtt_stats_.ExpireSmoothedMetrics();
EXPECT_EQ(doubled_rtt, rtt_stats_.smoothed_rtt());
- EXPECT_EQ(initial_rtt.Multiply(0.875), rtt_stats_.mean_deviation());
+ EXPECT_EQ(0.875 * initial_rtt, rtt_stats_.mean_deviation());
// Now go back down to 5ms and expire the smoothed metrics, and ensure the
// mean deviation increases to 15ms.
- QuicTime::Delta half_rtt = initial_rtt.Multiply(0.5);
+ QuicTime::Delta half_rtt = 0.5 * initial_rtt;
rtt_stats_.UpdateRtt(half_rtt, QuicTime::Delta::Zero(), QuicTime::Zero());
EXPECT_GT(doubled_rtt, rtt_stats_.smoothed_rtt());
EXPECT_LT(initial_rtt, rtt_stats_.mean_deviation());
« no previous file with comments | « net/quic/congestion_control/rtt_stats.cc ('k') | net/quic/congestion_control/send_algorithm_interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698