Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py

Issue 2130093003: Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2011 Google Inc. All rights reserved. 1 # Copyright (C) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions 4 # modification, are permitted provided that the following conditions
5 # are met: 5 # are met:
6 # 6 #
7 # 1. Redistributions of source code must retain the above copyright 7 # 1. Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # 2. Redistributions in binary form must reproduce the above copyright 9 # 2. Redistributions in binary form must reproduce the above copyright
10 # notice, this list of conditions and the following disclaimer in the 10 # notice, this list of conditions and the following disclaimer in the
(...skipping 11 matching lines...) Expand all
22 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 22 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
23 23
24 import unittest 24 import unittest
25 25
26 from webkitpy.common.system.crashlogs import CrashLogs 26 from webkitpy.common.system.crashlogs import CrashLogs
27 from webkitpy.common.system.filesystem_mock import MockFileSystem 27 from webkitpy.common.system.filesystem_mock import MockFileSystem
28 from webkitpy.common.system.systemhost import SystemHost 28 from webkitpy.common.system.systemhost import SystemHost
29 from webkitpy.common.system.systemhost_mock import MockSystemHost 29 from webkitpy.common.system.systemhost_mock import MockSystemHost
30 30
31 31
32 # pylint: disable=line-too-long
32 def make_mock_crash_report_darwin(process_name, pid): 33 def make_mock_crash_report_darwin(process_name, pid):
33 return """Process: {process_name} [{pid}] 34 return """Process: {process_name} [{pid}]
34 Path: /Volumes/Data/slave/snowleopard-intel-release-tests/build/WebKi tBuild/Release/{process_name} 35 Path: /Volumes/Data/slave/snowleopard-intel-release-tests/build/WebKi tBuild/Release/{process_name}
35 Identifier: {process_name} 36 Identifier: {process_name}
36 Version: ??? (???) 37 Version: ??? (???)
37 Code Type: X86-64 (Native) 38 Code Type: X86-64 (Native)
38 Parent Process: Python [2578] 39 Parent Process: Python [2578]
39 40
40 Date/Time: 2011-12-07 13:27:34.816 -0800 41 Date/Time: 2011-12-07 13:27:34.816 -0800
41 OS Version: Mac OS X 10.6.8 (10K549) 42 OS Version: Mac OS X 10.6.8 (10K549)
(...skipping 17 matching lines...) Expand all
59 0x7fff5fc00000 - 0x7fff5fc3be0f dyld 132.1 (???) <29DECB19-0193-2575-D8 38-CF743F0400B2> /usr/lib/dyld 60 0x7fff5fc00000 - 0x7fff5fc3be0f dyld 132.1 (???) <29DECB19-0193-2575-D8 38-CF743F0400B2> /usr/lib/dyld
60 61
61 System Profile: 62 System Profile:
62 Model: Xserve3,1, BootROM XS31.0081.B04, 8 processors, Quad-Core Intel Xeon, 2.2 6 GHz, 6 GB, SMC 1.43f4 63 Model: Xserve3,1, BootROM XS31.0081.B04, 8 processors, Quad-Core Intel Xeon, 2.2 6 GHz, 6 GB, SMC 1.43f4
63 Graphics: NVIDIA GeForce GT 120, NVIDIA GeForce GT 120, PCIe, 256 MB 64 Graphics: NVIDIA GeForce GT 120, NVIDIA GeForce GT 120, PCIe, 256 MB
64 Memory Module: global_name 65 Memory Module: global_name
65 Network Service: Ethernet 2, Ethernet, en1 66 Network Service: Ethernet 2, Ethernet, en1
66 PCI Card: NVIDIA GeForce GT 120, sppci_displaycontroller, MXM-Slot 67 PCI Card: NVIDIA GeForce GT 120, sppci_displaycontroller, MXM-Slot
67 Serial ATA Device: OPTIARC DVD RW AD-5670S 68 Serial ATA Device: OPTIARC DVD RW AD-5670S
68 """.format(process_name=process_name, pid=pid) 69 """.format(process_name=process_name, pid=pid)
70 # pylint: enable=line-too-long
69 71
70 72
71 class CrashLogsTest(unittest.TestCase): 73 class CrashLogsTest(unittest.TestCase):
72 74
73 def test_find_log_darwin(self): 75 def test_find_log_darwin(self):
74 if not SystemHost().platform.is_mac(): 76 if not SystemHost().platform.is_mac():
75 return 77 return
76 78
77 older_mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree' , 28528) 79 older_mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree' , 28528)
78 mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree', 2853 0) 80 mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree', 2853 0)
79 newer_mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree' , 28529) 81 newer_mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree' , 28529)
80 other_process_mock_crash_report = make_mock_crash_report_darwin('FooProc ess', 28527) 82 other_process_mock_crash_report = make_mock_crash_report_darwin('FooProc ess', 28527)
81 misformatted_mock_crash_report = 'Junk that should not appear in a crash report' + \ 83 misformatted_mock_crash_report = 'Junk that should not appear in a crash report' + \
82 make_mock_crash_report_darwin('DumpRenderTree', 28526)[200:] 84 make_mock_crash_report_darwin('DumpRenderTree', 28526)[200:]
83 files = {} 85 files = {}
86 # pylint: disable=line-too-long
84 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150718_quadzen.crash'] = older_mock_crash_report 87 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150718_quadzen.crash'] = older_mock_crash_report
85 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150719_quadzen.crash'] = mock_crash_report 88 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150719_quadzen.crash'] = mock_crash_report
86 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150720_quadzen.crash'] = newer_mock_crash_report 89 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150720_quadzen.crash'] = newer_mock_crash_report
87 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150721_quadzen.crash'] = None 90 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150721_quadzen.crash'] = None
88 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150722_quadzen.crash'] = other_process_mock_crash_report # noqa 91 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150722_quadzen.crash'] = other_process_mock_crash_report
89 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150723_quadzen.crash'] = misformatted_mock_crash_report # noqa 92 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150723_quadzen.crash'] = misformatted_mock_crash_report
93 # pylint: enable=line-too-long
90 filesystem = MockFileSystem(files) 94 filesystem = MockFileSystem(files)
91 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem)) 95 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem))
92 log = crash_logs.find_newest_log("DumpRenderTree") 96 log = crash_logs.find_newest_log("DumpRenderTree")
93 self.assertMultiLineEqual(log, newer_mock_crash_report) 97 self.assertMultiLineEqual(log, newer_mock_crash_report)
94 log = crash_logs.find_newest_log("DumpRenderTree", 28529) 98 log = crash_logs.find_newest_log("DumpRenderTree", 28529)
95 self.assertMultiLineEqual(log, newer_mock_crash_report) 99 self.assertMultiLineEqual(log, newer_mock_crash_report)
96 log = crash_logs.find_newest_log("DumpRenderTree", 28530) 100 log = crash_logs.find_newest_log("DumpRenderTree", 28530)
97 self.assertMultiLineEqual(log, mock_crash_report) 101 self.assertMultiLineEqual(log, mock_crash_report)
98 log = crash_logs.find_newest_log("DumpRenderTree", 28531) 102 log = crash_logs.find_newest_log("DumpRenderTree", 28531)
99 self.assertIsNone(log) 103 self.assertIsNone(log)
100 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0) 104 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0)
101 self.assertIsNone(log) 105 self.assertIsNone(log)
102 106
103 def bad_read(path): 107 def bad_read(_):
104 raise IOError('IOError: No such file or directory') 108 raise IOError('IOError: No such file or directory')
105 109
106 def bad_mtime(path): 110 def bad_mtime(_):
107 raise OSError('OSError: No such file or directory') 111 raise OSError('OSError: No such file or directory')
108 112
109 filesystem.read_text_file = bad_read 113 filesystem.read_text_file = bad_read
110 log = crash_logs.find_newest_log("DumpRenderTree", 28531, include_errors =True) 114 log = crash_logs.find_newest_log("DumpRenderTree", 28531, include_errors =True)
111 self.assertIn('IOError: No such file or directory', log) 115 self.assertIn('IOError: No such file or directory', log)
112 116
113 filesystem = MockFileSystem(files) 117 filesystem = MockFileSystem(files)
114 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem)) 118 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem))
115 filesystem.mtime = bad_mtime 119 filesystem.mtime = bad_mtime
116 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0, inclu de_errors=True) 120 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0, inclu de_errors=True)
117 self.assertIn('OSError: No such file or directory', log) 121 self.assertIn('OSError: No such file or directory', log)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698