Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4597)

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc

Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi
Patch Set: Apply feedback from review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc
diff --git a/chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc b/chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc
index 27c3faa54c4d3e36890365a72bb4dab98d6fc295..f1718f5c397843ce8543b99e15a192a733cc1472 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc
+++ b/chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc
@@ -11,6 +11,8 @@
#include "chrome/browser/sync/glue/session_model_associator.h"
#include "chrome/browser/sync/open_tabs_ui_delegate.h"
#include "chrome/browser/sync/sessions2/sessions_sync_manager.h"
+#include "sync/api/attachments/attachment_id.h"
+#include "sync/api/attachments/attachment_service_proxy_for_test.h"
#include "sync/protocol/session_specifics.pb.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -193,15 +195,25 @@ void RecentTabsBuilderTestHelper::ExportToSessionsSyncManager(
sync_pb::SessionSpecifics* tab_base = entity.mutable_session();
BuildTabSpecifics(s, w, t, tab_base);
changes.push_back(syncer::SyncChange(
- FROM_HERE, syncer::SyncChange::ACTION_ADD,
+ FROM_HERE,
+ syncer::SyncChange::ACTION_ADD,
syncer::SyncData::CreateRemoteData(
- tab_base->tab_node_id(), entity, GetTabTimestamp(s, w, t))));
+ tab_base->tab_node_id(),
+ entity,
+ GetTabTimestamp(s, w, t),
+ syncer::AttachmentIdList(),
+ syncer::AttachmentServiceProxyForTest::Create())));
}
}
changes.push_back(syncer::SyncChange(
- FROM_HERE, syncer::SyncChange::ACTION_ADD,
- syncer::SyncData::CreateRemoteData(1, session_entity,
- GetSessionTimestamp(s))));
+ FROM_HERE,
+ syncer::SyncChange::ACTION_ADD,
+ syncer::SyncData::CreateRemoteData(
+ 1,
+ session_entity,
+ GetSessionTimestamp(s),
+ syncer::AttachmentIdList(),
+ syncer::AttachmentServiceProxyForTest::Create())));
}
manager->ProcessSyncChanges(FROM_HERE, changes);
VerifyExport(manager);

Powered by Google App Engine
This is Rietveld 408576698