chrome/browser/themes/theme_syncable_service_unittest.cc - Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_syncable_service_unittest.cc

Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi

Patch Set: Apply feedback from review Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc ('k') | chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/theme_syncable_service_unittest.cc

diff --git a/chrome/browser/themes/theme_syncable_service_unittest.cc b/chrome/browser/themes/theme_syncable_service_unittest.cc

index 9ab01750d4712dbc5e860d8e68d612b416be31f5..254bd5b064ace2b6dca982b1ddf10a6219f5ff92 100644

--- a/chrome/browser/themes/theme_syncable_service_unittest.cc

+++ b/chrome/browser/themes/theme_syncable_service_unittest.cc

@@ -22,6 +22,8 @@

#include "extensions/common/manifest_constants.h"

#include "extensions/common/permissions/api_permission_set.h"

#include "extensions/common/permissions/permission_set.h"

+#include "sync/api/attachments/attachment_id.h"

+#include "sync/api/attachments/attachment_service_proxy_for_test.h"

#include "sync/api/fake_sync_change_processor.h"

#include "sync/api/sync_change_processor_wrapper_for_test.h"

#include "sync/api/sync_error.h"

@@ -451,11 +453,15 @@ TEST_F(ThemeSyncableServiceTest, ProcessSyncThemeChange) {

sync_pb::EntitySpecifics entity_specifics;

entity_specifics.mutable_theme()->CopyFrom(theme_specifics);

syncer::SyncChangeList change_list;

- change_list.push_back(syncer::SyncChange(

- FROM_HERE,

- syncer::SyncChange::ACTION_UPDATE,

- syncer::SyncData::CreateRemoteData(

- 1, entity_specifics, base::Time())));

+ change_list.push_back(

+ syncer::SyncChange(FROM_HERE,

+ syncer::SyncChange::ACTION_UPDATE,

+ syncer::SyncData::CreateRemoteData(

+ 1,

+ entity_specifics,

+ base::Time(),

+ syncer::AttachmentIdList(),

+ syncer::AttachmentServiceProxyForTest::Create())));

error = theme_sync_service_->ProcessSyncChanges(FROM_HERE, change_list);

EXPECT_FALSE(error.IsSet()) << error.message();

EXPECT_EQ(fake_theme_service_->theme_extension(), theme_extension_.get());