Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: sync/api/sync_change_unittest.cc

Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi
Patch Set: Merge with master. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/api/sync_change_unittest.cc
diff --git a/sync/api/sync_change_unittest.cc b/sync/api/sync_change_unittest.cc
index 5f937ab7c969347f71438939245b25fbf62943c1..574ee362e1f25177eedd7b5bc14a7119fe792fec 100644
--- a/sync/api/sync_change_unittest.cc
+++ b/sync/api/sync_change_unittest.cc
@@ -7,8 +7,11 @@
#include <string>
#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
#include "base/time/time.h"
#include "base/values.h"
+#include "sync/api/attachments/attachment_id.h"
+#include "sync/api/attachments/attachment_service_proxy_for_test.h"
#include "sync/protocol/preference_specifics.pb.h"
#include "sync/protocol/proto_value_conversions.h"
#include "sync/protocol/sync.pb.h"
@@ -21,7 +24,10 @@ typedef std::vector<SyncChange> SyncChangeList;
namespace {
-typedef testing::Test SyncChangeTest;
+class SyncChangeTest : public testing::Test {
+ private:
+ base::MessageLoop message_loop;
+};
TEST_F(SyncChangeTest, LocalDelete) {
SyncChange::SyncChangeType change_type = SyncChange::ACTION_DELETE;
@@ -85,7 +91,11 @@ TEST_F(SyncChangeTest, SyncerChanges) {
change_list.push_back(SyncChange(
FROM_HERE,
SyncChange::ACTION_UPDATE,
- SyncData::CreateRemoteData(1, update_specifics, base::Time())));
+ SyncData::CreateRemoteData(1,
+ update_specifics,
+ base::Time(),
+ syncer::AttachmentIdList(),
+ syncer::AttachmentServiceProxyForTest())));
// Create an add.
sync_pb::EntitySpecifics add_specifics;
@@ -94,7 +104,11 @@ TEST_F(SyncChangeTest, SyncerChanges) {
change_list.push_back(SyncChange(
FROM_HERE,
SyncChange::ACTION_ADD,
- SyncData::CreateRemoteData(2, add_specifics, base::Time())));
+ SyncData::CreateRemoteData(2,
+ add_specifics,
+ base::Time(),
+ syncer::AttachmentIdList(),
+ syncer::AttachmentServiceProxyForTest())));
// Create a delete.
sync_pb::EntitySpecifics delete_specifics;
@@ -103,7 +117,11 @@ TEST_F(SyncChangeTest, SyncerChanges) {
change_list.push_back(SyncChange(
FROM_HERE,
SyncChange::ACTION_DELETE,
- SyncData::CreateRemoteData(3, delete_specifics, base::Time())));
+ SyncData::CreateRemoteData(3,
+ delete_specifics,
+ base::Time(),
+ syncer::AttachmentIdList(),
+ syncer::AttachmentServiceProxyForTest())));
ASSERT_EQ(3U, change_list.size());

Powered by Google App Engine
This is Rietveld 408576698