Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: sync/api/sync_data.h

Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi
Patch Set: Merge with master. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/api/sync_data.h
diff --git a/sync/api/sync_data.h b/sync/api/sync_data.h
index 717b1e1175d5b5f9e0bbc797928118fb9b0388ad..72706b016550203057df20f6195476c88624021e 100644
--- a/sync/api/sync_data.h
+++ b/sync/api/sync_data.h
@@ -64,18 +64,12 @@ class SYNC_EXPORT SyncData {
const AttachmentList& attachments);
// Helper method for creating SyncData objects originating from the syncer.
- //
- // TODO(maniscalco): Replace all calls to 3-arg CreateRemoteData with calls to
- // the 5-arg version (bug 353296).
static SyncData CreateRemoteData(
int64 id,
const sync_pb::EntitySpecifics& specifics,
const base::Time& last_modified_time,
const AttachmentIdList& attachment_ids,
const syncer::AttachmentServiceProxy& attachment_service);
- static SyncData CreateRemoteData(int64 id,
- const sync_pb::EntitySpecifics& specifics,
- const base::Time& last_modified_time);
// Whether this SyncData holds valid data. The only way to have a SyncData
// without valid data is to use the default constructor.

Powered by Google App Engine
This is Rietveld 408576698