Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 213003002: DevTools: allow whitelist of timeline events to be pushed live although in bufferEvent mode. (Closed)

Created:
6 years, 9 months ago by pfeldman
Modified:
6 years, 9 months ago
Reviewers:
caseq
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: allow whitelist of timeline events to be pushed live although in bufferEvent mode. R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170186

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Same with front-end #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -32 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector-protocol/timeline/timeline-start-bufferEvents.html View 1 chunk +24 lines, -10 lines 0 comments Download
M LayoutTests/inspector-protocol/timeline/timeline-start-bufferEvents-expected.txt View 1 chunk +10 lines, -1 line 0 comments Download
M Source/core/inspector/CodeGeneratorInspector.py View 1 2 chunks +12 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 4 chunks +5 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 8 chunks +27 lines, -5 lines 0 comments Download
M Source/core/inspector/TimelineRecordFactory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/TimelineRecordFactory.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/devtools/front_end/TimelineFrameModel.js View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M Source/devtools/front_end/TimelineManager.js View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/TimelineModel.js View 1 2 2 chunks +23 lines, -9 lines 1 comment Download
M Source/devtools/front_end/TimelinePanel.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pfeldman
6 years, 9 months ago (2014-03-26 14:54:15 UTC) #1
caseq
lgtm https://codereview.chromium.org/213003002/diff/60001/Source/devtools/front_end/TimelineModel.js File Source/devtools/front_end/TimelineModel.js (right): https://codereview.chromium.org/213003002/diff/60001/Source/devtools/front_end/TimelineModel.js#newcode224 Source/devtools/front_end/TimelineModel.js:224: WebInspector.TimelineModel.RecordType.DrawFrame, Wring indent
6 years, 9 months ago (2014-03-26 16:21:06 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 9 months ago (2014-03-27 13:12:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/213003002/60001
6 years, 9 months ago (2014-03-27 13:13:04 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:27:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 14:27:13 UTC) #6
pfeldman
6 years, 9 months ago (2014-03-27 15:07:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r170186 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698