Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: Source/core/inspector/CodeGeneratorInspector.py

Issue 213003002: DevTools: allow whitelist of timeline events to be pushed live although in bufferEvent mode. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Same with front-end Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/CodeGeneratorInspector.py
diff --git a/Source/core/inspector/CodeGeneratorInspector.py b/Source/core/inspector/CodeGeneratorInspector.py
index 506b321c9b7d57aa477a347a61df690227c33be3..b703b6a565b98df3dd57a00c5de3c406e3b73e57 100755
--- a/Source/core/inspector/CodeGeneratorInspector.py
+++ b/Source/core/inspector/CodeGeneratorInspector.py
@@ -1193,6 +1193,18 @@ class TypeBindings:
writer.newline(" typedef TypeBuilder::StructItemTraits ItemTraits;\n")
+ for prop_data in resolve_data.main_properties:
+ prop_name = prop_data.p["name"]
+ param_type_binding = prop_data.param_type_binding
+ raw_type = param_type_binding.reduce_to_raw_type()
+ if isinstance(param_type_binding.get_type_model(), TypeModel.ValueType):
+ writer.append_multiline("\n void %s" % prop_name)
+ writer.append("(%s value)\n" % param_type_binding.get_type_model().get_command_return_pass_model().get_output_parameter_type())
+ writer.newline(" {\n")
+ writer.newline(" JSONObjectBase::get%s(\"%s\", value);\n"
+ % (param_type_binding.reduce_to_raw_type().get_setter_name(), prop_data.p["name"]))
+ writer.newline(" }\n")
+
for prop_data in resolve_data.optional_properties:
prop_name = prop_data.p["name"]
param_type_binding = prop_data.param_type_binding
@@ -1206,7 +1218,6 @@ class TypeBindings:
format_setter_value_expression(param_type_binding, "value")))
writer.newline(" }\n")
-
if setter_name in INSPECTOR_OBJECT_SETTER_NAMES:
writer.newline(" using JSONObjectBase::%s;\n\n" % setter_name)

Powered by Google App Engine
This is Rietveld 408576698