Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2129953002: Correctly handle mat2x2 in Vulkan (Closed)

Created:
4 years, 5 months ago by egdaniel
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M gyp/shaderc.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineStateDataManager.cpp View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M src/gpu/vk/GrVkUniformHandler.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
egdaniel
4 years, 5 months ago (2016-07-07 14:31:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129953002/20001
4 years, 5 months ago (2016-07-07 14:31:36 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 5 months ago (2016-07-07 14:31:38 UTC) #6
ethannicholas
lgtm with nit
4 years, 5 months ago (2016-07-07 14:35:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129953002/40001
4 years, 5 months ago (2016-07-07 14:39:43 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 15:04:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/75d2bfceaec7216414a7eb527807f2acac5cfd08

Powered by Google App Engine
This is Rietveld 408576698