Added UMA Metrics for SMS UI in the status area.

Added UMA Metrics for SMS UI in the status area.

Record user actions when:
- SMS Detailed view is shown
- SMS message is dismissed from the detailed view
- SMS message is dismissed from the notification view

BUG=620508
TEST=Manual

Committed: https://crrev.com/3ade47d22f4f8db110794eddce6b303f57b0d36c
Cr-Commit-Position: refs/heads/master@{#404434}

[bruthig, 2016-07-07 17:24:24]

bruthig@chromium.org changed reviewers:
+ tdanderson@chromium.org

[bruthig, 2016-07-07 17:24:24]

Terry, can you take a first look?

[tdanderson, 2016-07-07 17:49:02]

LGTM with a few suggestions on phrasing

https://codereview.chromium.org/2129913003/diff/40001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2129913003/diff/40001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:13907: Counts the number of times the user has
clicked on the "SMS messages
I would word as "Counts the number of times the user has opened the SMS messages
detailed view in the system menu."

https://codereview.chromium.org/2129913003/diff/40001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:13917: SMS message detailed view in the status
tray.
"in the system menu" rather than "in the status tray"

https://codereview.chromium.org/2129913003/diff/40001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:13926: SMS message notification view in the
status tray.
Technically should also be "in the system menu" but from the user's point of
view this shows up as a standalone notification outside of the notifications
center. So I'd suggest just "Counts the number of times the user has dismissed
an SMS message notification."

[bruthig, 2016-07-07 17:52:55]

bruthig@chromium.org changed reviewers:
+ jamescook@chromium.org, rkaplow@chromium.org

[bruthig, 2016-07-07 17:52:55]

jamescook@, can you please review changes in:
 - ash/common/*

rkaplow@, can you please review changes in:
 - tools/metrics/actions/actions.xml

[stevenjb, 2016-07-07 17:54:35]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org
- jamescook@chromium.org, rkaplow@chromium.org

[stevenjb, 2016-07-07 17:54:36]

Thanks for taking this on.

One thing to note: This UI exists primarily for customers in countries where SMS
is required to activate a cellular data plan. I don't know whether or not we
reliably get UMA stats in those cases.

i.e. this may fall into the category of something that almost nobody reports
using, but the handful that do rely on it.

https://codereview.chromium.org/2129913003/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/network/tray_sms.cc (right):

https://codereview.chromium.org/2129913003/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/network/tray_sms.cc:405: messages_.Remove(index,
NULL);
NULL -> nullptr throughout the file

[stevenjb, 2016-07-07 17:54:50]

Oh, and lgtm

[James Cook, 2016-07-07 17:57:48]

jamescook@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2016-07-07 17:57:49]

ash/common lgtm

[bruthig, 2016-07-07 18:01:39]

https://codereview.chromium.org/2129913003/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/network/tray_sms.cc (right):

https://codereview.chromium.org/2129913003/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/network/tray_sms.cc:405: messages_.Remove(index,
NULL);
On 2016/07/07 17:54:36, stevenjb wrote:
> NULL -> nullptr throughout the file

Done.

https://codereview.chromium.org/2129913003/diff/40001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2129913003/diff/40001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:13907: Counts the number of times the user has
clicked on the "SMS messages
On 2016/07/07 17:49:02, tdanderson wrote:
> I would word as "Counts the number of times the user has opened the SMS
messages
> detailed view in the system menu."

Done.

https://codereview.chromium.org/2129913003/diff/40001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:13917: SMS message detailed view in the status
tray.
On 2016/07/07 17:49:02, tdanderson wrote:
> "in the system menu" rather than "in the status tray"

Done.

https://codereview.chromium.org/2129913003/diff/40001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:13926: SMS message notification view in the
status tray.
On 2016/07/07 17:49:02, tdanderson wrote:
> Technically should also be "in the system menu" but from the user's point of
> view this shows up as a standalone notification outside of the notifications
> center. So I'd suggest just "Counts the number of times the user has dismissed
> an SMS message notification."

Done.

[bruthig, 2016-07-07 18:04:44]

bruthig@chromium.org changed reviewers:
+ rkaplow@chromium.org

[bruthig, 2016-07-07 18:04:45]

Re-adding rkaplow@, not sure how you were removed.

[rkaplow, 2016-07-08 14:29:08]

lgtm

[bruthig, 2016-07-08 17:07:43]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2016-07-08 17:07:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, stevenjb@chromium.org, jamescook@chromium.org,
rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2129913003/#ps120001
(title: "Renamed UMA metrics.")

[commit-bot: I haz the power, 2016-07-08 17:08:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 17:58:53]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-08 17:58:57]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 18:01:30]

Description was changed from

==========
Added UMA Metrics for SMS UI in the status area.

Record user actions when:
- SMS Detailed view is shown
- SMS message is dismissed from the detailed view
- SMS message is dismissed from the notification view

BUG=620508
TEST=Manual
==========

to

==========
Added UMA Metrics for SMS UI in the status area.

Record user actions when:
- SMS Detailed view is shown
- SMS message is dismissed from the detailed view
- SMS message is dismissed from the notification view

BUG=620508
TEST=Manual

Committed: https://crrev.com/3ade47d22f4f8db110794eddce6b303f57b0d36c
Cr-Commit-Position: refs/heads/master@{#404434}
==========

[commit-bot: I haz the power, 2016-07-08 18:01:32]

Patchset 7 (id:??) landed as
https://crrev.com/3ade47d22f4f8db110794eddce6b303f57b0d36c
Cr-Commit-Position: refs/heads/master@{#404434}