Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: ash/common/system/chromeos/network/tray_sms.h

Issue 2129913003: Added UMA Metrics for SMS UI in the status area. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renamed UMA metrics. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/metrics/user_metrics_action.h ('k') | ash/common/system/chromeos/network/tray_sms.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/chromeos/network/tray_sms.h
diff --git a/ash/common/system/chromeos/network/tray_sms.h b/ash/common/system/chromeos/network/tray_sms.h
index c8209a0029def28076b88d3626ba90b943631de5..4ad9322b019ae49bdc8e9cc0adc552e1a6f49d2e 100644
--- a/ash/common/system/chromeos/network/tray_sms.h
+++ b/ash/common/system/chromeos/network/tray_sms.h
@@ -43,8 +43,9 @@ class TraySms : public SystemTrayItem,
// retrieve the numebr and text from the message.
bool GetLatestMessage(size_t* index, std::string* number, std::string* text);
- // Removes message at |index| from message list.
- void RemoveMessage(size_t index);
+ // Removes message at |index| from message list. Returns true if |index| was
+ // valid and a message was removed.
+ bool RemoveMessage(size_t index);
// Called when sms messages have changed (through
// chromeos::NetworkSmsHandler::Observer).
« no previous file with comments | « ash/common/metrics/user_metrics_action.h ('k') | ash/common/system/chromeos/network/tray_sms.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698