Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2129893002: Mark win_xfa_clang as experimental (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Mark win_xfa_clang as experimental That way it won't block the CQ while the compile problems are being investigated. BUG=chromium:626120 NOTRY=true (otherwise, win_xfa_clang will fail and block this CL) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9a53675a6834d9ca82ac7b593123078de3748e11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M infra/config/cq.cfg View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-07 10:56:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129893002/1
4 years, 5 months ago (2016-07-07 10:56:44 UTC) #3
Sergiy Byelozyorov (Google)
thanks a lot, LGTM
4 years, 5 months ago (2016-07-07 10:58:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129893002/1
4 years, 5 months ago (2016-07-07 11:01:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/9a53675a6834d9ca82ac7b593123078de3748e11
4 years, 5 months ago (2016-07-07 11:01:21 UTC) #11
Lei Zhang
4 years, 5 months ago (2016-07-07 19:09:39 UTC) #12
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698