Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2129883002: Relax strict restriction on position of line-continuation (Closed)

Created:
4 years, 5 months ago by qiankun
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relax strict restriction on position of line-continuation This fixes comments#19 in https://codereview.chromium.org/2082483002/. BUG=295792 TEST=deqp/data/gles3/shaders/preprocessor.html CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/35c8d1f820bf8d439088da996941207004358ebc Cr-Commit-Position: refs/heads/master@{#404335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
qiankun
PTAL. Also Test updated: https://github.com/KhronosGroup/WebGL/pull/1849
4 years, 5 months ago (2016-07-07 10:34:40 UTC) #3
qiankun
On 2016/07/07 10:34:40, qiankun wrote: > PTAL. > Also Test updated: https://github.com/KhronosGroup/WebGL/pull/1849 This test can ...
4 years, 5 months ago (2016-07-07 15:10:14 UTC) #4
Zhenyao Mo
On 2016/07/07 15:10:14, qiankun wrote: > On 2016/07/07 10:34:40, qiankun wrote: > > PTAL. > ...
4 years, 5 months ago (2016-07-07 16:21:34 UTC) #5
Ken Russell (switch to Gerrit)
lgtm too.
4 years, 5 months ago (2016-07-07 19:22:34 UTC) #6
Zhenyao Mo
FYI: WebGL test change is rolled in: https://codereview.chromium.org/2126383002/
4 years, 5 months ago (2016-07-07 20:27:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129883002/1
4 years, 5 months ago (2016-07-08 01:40:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-08 03:42:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129883002/1
4 years, 5 months ago (2016-07-08 06:34:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 09:43:51 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 09:43:53 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 09:47:05 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35c8d1f820bf8d439088da996941207004358ebc
Cr-Commit-Position: refs/heads/master@{#404335}

Powered by Google App Engine
This is Rietveld 408576698