Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: Source/core/core_generated.gyp

Issue 212983010: Make EventInterfaces.in build step not depend on bindings generation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/core_generated.gyp
diff --git a/Source/core/core_generated.gyp b/Source/core/core_generated.gyp
index 45ecff6f9a8eeb561793c64dde0ff25fd67e3fb2..5ae89a3dd7e5cdc136e974f5aef331d1141fe5c8 100644
--- a/Source/core/core_generated.gyp
+++ b/Source/core/core_generated.gyp
@@ -32,6 +32,7 @@
'includes': [
'core.gypi',
'../bindings/bindings.gypi',
+ '../modules/modules.gypi', # for list of event IDL files
Nils Barth (inactive) 2014/03/27 06:43:51 I suspect we don't want core/ to depend on modules
haraken 2014/03/27 07:08:59 Yeah, I don't think it's a right thing to make cor
Nils Barth (inactive) 2014/03/27 07:14:12 core/ already depends on bindings/ that depends on
'../build/features.gypi',
'../build/scripts/scripts.gypi',
],
@@ -423,6 +424,34 @@
],
},
{
+ 'action_name': 'EventInterfaces',
+ 'variables': {
+ 'event_idl_files': [
+ '<@(core_event_idl_files)',
+ '<@(modules_event_idl_files)',
+ ],
+ 'event_idl_files_list':
+ '<|(event_idl_files_list.tmp <@(event_idl_files))',
+ },
+ 'inputs': [
+ '../bindings/scripts/generate_event_interfaces.py',
Nils Barth (inactive) 2014/03/27 06:43:51 Will move to build/scripts in followup.
+ '../bindings/scripts/utilities.py',
+ '<@(event_idl_files)',
+ ],
+ 'outputs': [
+ '<(SHARED_INTERMEDIATE_DIR)/blink/EventInterfaces.in',
+ ],
+ 'action': [
+ 'python',
+ '../bindings/scripts/generate_event_interfaces.py',
+ '--event-idl-files-list',
+ '<@(event_idl_files_list)',
+ '--event-interfaces-file',
+ '<(SHARED_INTERMEDIATE_DIR)/blink/EventInterfaces.in',
+ '<@(write_file_only_if_changed)',
+ ],
+ },
+ {
'action_name': 'EventFactory',
'inputs': [
'<@(make_event_factory_files)',

Powered by Google App Engine
This is Rietveld 408576698