Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: Source/bindings/generated_bindings.gyp

Issue 212983010: Make EventInterfaces.in build step not depend on bindings generation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/generated_bindings.gyp
diff --git a/Source/bindings/generated_bindings.gyp b/Source/bindings/generated_bindings.gyp
index dd9cf36b9534fe2cc31f05c4e583dd564ed75dd4..932912f6d5aa970e81036d166b7633d06b87b764 100644
--- a/Source/bindings/generated_bindings.gyp
+++ b/Source/bindings/generated_bindings.gyp
@@ -167,23 +167,6 @@
'templates/interface.h',
'templates/methods.cpp',
],
-
-
- 'bindings_output_dir': '<(SHARED_INTERMEDIATE_DIR)/blink/bindings',
-
- 'conditions': [
- # The bindings generator can skip writing generated files if they are
- # identical to the already existing file, which avoids recompilation.
- # However, a dependency (earlier build step) having a newer timestamp than
- # an output (later build step) confuses some build systems, so only use
- # this on ninja, which explicitly supports this use case (gyp turns all
- # actions into ninja restat rules).
- ['"<(GENERATOR)"=="ninja"', {
- 'write_file_only_if_changed': '--write-file-only-if-changed 1',
- }, {
- 'write_file_only_if_changed': '--write-file-only-if-changed 0',
- }],
- ],
},
'targets': [
@@ -264,35 +247,6 @@
},
################################################################################
{
- 'target_name': 'event_interfaces',
- 'type': 'none',
- 'dependencies': [
- 'interfaces_info',
- ],
- 'actions': [{
- 'action_name': 'generate_event_interfaces',
- 'inputs': [
- 'scripts/generate_event_interfaces.py',
- 'scripts/utilities.py',
- '<(SHARED_INTERMEDIATE_DIR)/blink/InterfacesInfo.pickle',
- ],
- 'outputs': [
- '<(SHARED_INTERMEDIATE_DIR)/blink/EventInterfaces.in',
- ],
- 'action': [
- 'python',
- 'scripts/generate_event_interfaces.py',
- '--interfaces-info-file',
- '<(SHARED_INTERMEDIATE_DIR)/blink/InterfacesInfo.pickle',
- '--event-interfaces-file',
- '<(SHARED_INTERMEDIATE_DIR)/blink/EventInterfaces.in',
- '<@(write_file_only_if_changed)',
- ],
- 'message': 'Generating list of Event interfaces',
- }]
- },
-################################################################################
- {
# A separate pre-caching step is *not required* to use lex/parse table
# caching in PLY, as the caches are concurrency-safe.
# However, pre-caching ensures that all compiler processes use the cached
@@ -437,7 +391,6 @@
'type': 'none',
'dependencies': [
'aggregate_generated_bindings',
- 'event_interfaces',
Nils Barth (inactive) 2014/03/27 06:43:51 ! Now 'generated_bindings' actually only generates
'individual_generated_bindings',
],
},

Powered by Google App Engine
This is Rietveld 408576698