Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: Source/bindings/bindings.gypi

Issue 212983010: Make EventInterfaces.in build step not depend on bindings generation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/generated_bindings.gyp » ('j') | Source/bindings/generated_bindings.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/bindings.gypi
diff --git a/Source/bindings/bindings.gypi b/Source/bindings/bindings.gypi
index 1c9670ddbe8e7848778dd862dcd2554e176405d4..5fbad6ad17048254c38d44b2dcdb294db462a2a5 100644
--- a/Source/bindings/bindings.gypi
+++ b/Source/bindings/bindings.gypi
@@ -1,6 +1,7 @@
{
'variables': {
- 'bindings_dir': ['.'],
+ 'bindings_dir': '.',
+ 'bindings_output_dir': '<(SHARED_INTERMEDIATE_DIR)/blink/bindings',
'bindings_files': [
'v8/ActiveDOMCallback.cpp',
'v8/ActiveDOMCallback.h',
@@ -274,6 +275,18 @@
'<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings19.cpp',
],
}],
+
+ # The bindings generator can skip writing generated files if they are
+ # identical to the already existing file, which avoids recompilation.
+ # However, a dependency (earlier build step) having a newer timestamp
+ # than an output (later build step) confuses some build systems, so
+ # only use this on ninja, which explicitly supports this use case
+ # (gyp turns all actions into ninja restat rules).
+ ['"<(GENERATOR)"=="ninja"', {
+ 'write_file_only_if_changed': '--write-file-only-if-changed 1',
Nils Barth (inactive) 2014/03/27 06:43:51 Needed by core.gyp, so move into .gypi, which is w
+ }, {
+ 'write_file_only_if_changed': '--write-file-only-if-changed 0',
+ }],
],
},
}
« no previous file with comments | « no previous file | Source/bindings/generated_bindings.gyp » ('j') | Source/bindings/generated_bindings.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698