Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2129803002: Revert of pepper: parse context creation attrib list on the plugin side (Closed)

Created:
4 years, 5 months ago by brucedawson
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gpu_pref_size_in_attrs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of pepper: parse context creation attrib list on the plugin side (patchset #7 id:120001 of https://codereview.chromium.org/2104403003/ ) Reason for revert: Build errors including x86/x64 mismatches: https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/416/steps/compile/logs/stdio Original issue's description: > pepper: parse context creation attrib list on the plugin side > > This is simpler because we don't need to parse and copy lists of attributes. > We now only parse them in the same process that creates them, avoiding potential security issues. > > BUG=None > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/de2733a7d9c32815d4195e067dd628399f5996fc > Cr-Commit-Position: refs/heads/master@{#404024} TBR=bbudge@chromium.org,dcheng@chromium.org,danakj@chromium.org,bradnelson@chromium.org,bradnelson@google.com,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/39c812dd971e69397daec3d9ba31136c9d4c845d Cr-Commit-Position: refs/heads/master@{#404030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -274 lines) Patch
M components/nacl_nonsfi.gyp View 3 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.h View 3 chunks +7 lines, -11 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.cc View 4 chunks +42 lines, -9 lines 0 comments Download
M content/renderer/pepper/resource_creation_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/resource_creation_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/command_buffer_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer_traits.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/gpu_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/common/gpu_command_buffer_traits_multi.h View 3 chunks +0 lines, -24 lines 0 comments Download
M gpu/ipc/common/gpu_param_traits_macros.h View 5 chunks +23 lines, -0 lines 0 comments Download
M ppapi/native_client/native_client.gyp View 5 chunks +0 lines, -10 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +8 lines, -9 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 2 chunks +1 line, -4 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 3 chunks +21 lines, -31 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/resource_creation_api.h View 2 chunks +1 line, -4 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +50 lines, -1 line 0 comments Download
D ui/gfx/gfx_geometry.gypi View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/gfx/gfx_nacl.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
M ui/gfx/ipc/geometry/gfx_ipc_geometry.gyp View 1 chunk +10 lines, -2 lines 0 comments Download
D ui/gfx/ipc/geometry/gfx_ipc_geometry.gypi View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/gfx/ipc/geometry/gfx_ipc_geometry_nacl.gyp View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
Created Revert of pepper: parse context creation attrib list on the plugin side
4 years, 5 months ago (2016-07-07 01:47:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129803002/1
4 years, 5 months ago (2016-07-07 01:48:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 01:49:28 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 01:49:35 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 01:50:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39c812dd971e69397daec3d9ba31136c9d4c845d
Cr-Commit-Position: refs/heads/master@{#404030}

Powered by Google App Engine
This is Rietveld 408576698