Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1738)

Unified Diff: content/renderer/pepper/ppb_graphics_3d_impl.h

Issue 2129803002: Revert of pepper: parse context creation attrib list on the plugin side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gpu_pref_size_in_attrs
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl_nonsfi.gyp ('k') | content/renderer/pepper/ppb_graphics_3d_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/ppb_graphics_3d_impl.h
diff --git a/content/renderer/pepper/ppb_graphics_3d_impl.h b/content/renderer/pepper/ppb_graphics_3d_impl.h
index e9615a2768c92cd5ac7adaeaeda1ad9267b01262..abafd2c4b14bd0eaf87ca780c0f5e42d315e0ad9 100644
--- a/content/renderer/pepper/ppb_graphics_3d_impl.h
+++ b/content/renderer/pepper/ppb_graphics_3d_impl.h
@@ -20,9 +20,6 @@
#include "ppapi/shared_impl/resource.h"
namespace gpu {
-namespace gles2 {
-struct ContextCreationAttribHelper;
-}
struct Capabilities;
class CommandBufferProxyImpl;
}
@@ -32,13 +29,12 @@
class PPB_Graphics3D_Impl : public ppapi::PPB_Graphics3D_Shared,
public gpu::GpuControlClient {
public:
- static PP_Resource CreateRaw(
- PP_Instance instance,
- PP_Resource share_context,
- const gpu::gles2::ContextCreationAttribHelper& attrib_helper,
- gpu::Capabilities* capabilities,
- base::SharedMemoryHandle* shared_state_handle,
- gpu::CommandBufferId* command_buffer_id);
+ static PP_Resource CreateRaw(PP_Instance instance,
+ PP_Resource share_context,
+ const int32_t* attrib_list,
+ gpu::Capabilities* capabilities,
+ base::SharedMemoryHandle* shared_state_handle,
+ gpu::CommandBufferId* command_buffer_id);
// PPB_Graphics3D_API trusted implementation.
PP_Bool SetGetBuffer(int32_t transfer_buffer_id) override;
@@ -80,7 +76,7 @@
explicit PPB_Graphics3D_Impl(PP_Instance instance);
bool InitRaw(PPB_Graphics3D_API* share_context,
- const gpu::gles2::ContextCreationAttribHelper& attrib_helper,
+ const int32_t* attrib_list,
gpu::Capabilities* capabilities,
base::SharedMemoryHandle* shared_state_handle,
gpu::CommandBufferId* command_buffer_id);
« no previous file with comments | « components/nacl_nonsfi.gyp ('k') | content/renderer/pepper/ppb_graphics_3d_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698